br: drop a fixme in br since its 8.0+ now#62914
Conversation
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
|
[FORMAT CHECKER NOTIFICATION] Notice: To remove the 📖 For more info, you can check the "Contribute Code" section in the development guide. Notice: To remove the For example:
📖 For more info, you can check the "Contribute Code" section in the development guide. |
|
Hi @yihong0618. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @yihong0618. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| return nil, errors.Trace(err) | ||
| } | ||
| // we must check tidb(tikv version) any time after concurrent ddl feature implemented in v6.2. | ||
| // we will keep this check until 7.0, which allow the breaking changes. |
There was a problem hiding this comment.
maybe it means BR can run on an old version cluster. @Leavrth can you take a look?
What problem does this PR solve?
Issue Number: ref: #36474
Problem Summary:
as tidb is 8.0+ now so this can drop maybe
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.