ddl: add realtikv test case for merge temp index #64436
Conversation
ti-chi-bot
Bot
added
release-note-none
|
Hi @fzzf678. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ti-chi-bot
Bot
added
approved
needs-1-more-lgtm
Benjamin2037
added
needs-rebase
| } | ||
| }) | ||
|
|
||
| time.Sleep(2 * time.Second) // wait workload run for a while |
There was a problem hiding this comment.
maybe use a counter for how many workload queries are run, and wait this counter value > some value, it's might cause flaky or unable to run the case in CI
There was a problem hiding this comment.
Updated, PTAL again
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #64436 +/- ##
================================================
+ Coverage 72.6827% 73.2650% +0.5823%
================================================
Files 1865 1867 +2
Lines 506065 508866 +2801
================================================
+ Hits 367822 372821 +4999
+ Misses 115852 113857 -1995
+ Partials 22391 22188 -203
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ti-chi-bot
Bot
added
size/L
fzzf678
removed
the
needs-rebase
Co-authored-by: Ruihao Chen <joechenrh@gmail.com>
…b into add_index_conflict_test_case
| for execCnt.Load() < 5000 { | ||
| time.Sleep(100 * time.Millisecond) | ||
| } |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, D3Hunter The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/retest |
|
@fzzf678: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@fzzf678: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
5 participants
What problem does this PR solve?
Issue Number: ref #61433
Problem Summary:
What changed and how does it work?
Add automated test cases for merge temp index stuck problem. In my test environment(MacBook Pro with Apple M4), this case takes about 16 second to complete. Before the commit #61445, this case will stuck and never success.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.