-
Notifications
You must be signed in to change notification settings - Fork 6.1k
executor: fix plan replayer cannot load bindings (#64802) #64848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-8.5
Are you sure you want to change the base?
executor: fix plan replayer cannot load bindings (#64802) #64848
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #64848 +/- ##
================================================
Coverage ? 75.0609%
================================================
Files ? 1657
Lines ? 458650
Branches ? 0
================================================
Hits ? 344267
Misses ? 93496
Partials ? 20887
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #64802
What problem does this PR solve?
Issue Number: close #64811
Problem Summary:
What changed and how does it work?
The original SQL in our bind info is actually normalized SQL, which cannot be executed directly. This is especially true for function names that are not defined as keywords, such as
countandifnull. These will be treated as strings and used to calculate the digest. Therefore, the original SQL cannot be directly used to construct the create binding. As a result, we have to resort to a more underlying method to write the binding.Check List
Tests
Run with the plan replayer testing with any load binding error.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.