Skip to content

tool: upgrade mysql-tester to show the diff | tidb-test=pr/2637 #64869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ti-chi-bot merged 1 commit into from
Dec 9, 2025
Merged

tool: upgrade mysql-tester to show the diff | tidb-test=pr/2637 #64869

ti-chi-bot merged 1 commit into from
Dec 9, 2025
+3 −3

Conversation

@hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Dec 5, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

When your result set changes significantly, it's not easy to directly discern the differences from the logs. I've modified the log format so that it can print the diff.

before

image

after the improvement

image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Dec 5, 2025
@hawkingrei hawkingrei added the skip-issue-check Indicates that a PR no need to check linked issue. label Dec 5, 2025
@hawkingrei hawkingrei changed the title tool: upgrade mysql-tester to show the diff tool: upgrade mysql-tester to show the diff | tidb-test=pr/2637 Dec 5, 2025
YangKeao
YangKeao approved these changes Dec 5, 2025
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 5, 2025
@hawkingrei hawkingrei requested review from xhebox and zimulala December 5, 2025 06:16
@codecov
Copy link

codecov bot commented Dec 5, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.4700%. Comparing base (ed787bf) to head (ad5353e).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #64869        +/-   ##
================================================
- Coverage   74.7004%   73.4700%   -1.2304%     
================================================
  Files          1893       1873        -20     
  Lines        516479     508964      -7515     
================================================
- Hits         385812     373936     -11876     
- Misses       106811     112775      +5964     
+ Partials      23856      22253      -1603
Flag Coverage Δ
integration 41.7880% <ø> (-6.3718%) ⬇️
unit 72.6234% <ø> (+0.3410%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 46.1182% <ø> (-16.5632%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YangKeao, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 5, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 5, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-05 06:13:19.603244505 +0000 UTC m=+589544.417022077: ☑️ agreed by YangKeao.
  • 2025-12-05 06:21:24.281579513 +0000 UTC m=+590029.095357085: ☑️ agreed by zimulala.

@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 5, 2025

/test all

@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 5, 2025

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2025
@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 5, 2025

/retest

7 similar comments
@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 5, 2025

/retest

@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 5, 2025

/retest

@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 5, 2025

/retest

@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 5, 2025

/retest

@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 5, 2025

/retest

@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 5, 2025

/retest

@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 5, 2025

/retest

@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 5, 2025

/retest

6 similar comments
@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 5, 2025

/retest

@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 5, 2025

/retest

@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 5, 2025

/retest

@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 5, 2025

/retest

@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 5, 2025

/retest

@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 5, 2025

/retest

@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 5, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2025
@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 5, 2025

/retest

6 similar comments
@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 5, 2025

/retest

@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 5, 2025

/retest

@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 5, 2025

/retest

@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 5, 2025

/retest

@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 6, 2025

/retest

@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 6, 2025

/retest

@hawkingrei hawkingrei force-pushed the upgrade_mysql_tester branch 2 times, most recently from 5096ea9 to a9e2a21 Compare December 6, 2025 09:43
@lance6716
Copy link
Contributor

lance6716 commented Dec 6, 2025

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 8, 2025

/retest

@hawkingrei hawkingrei force-pushed the upgrade_mysql_tester branch 2 times, most recently from 4937824 to d852db2 Compare December 8, 2025 11:00
@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 8, 2025

/retest

@hawkingrei hawkingrei force-pushed the upgrade_mysql_tester branch from d852db2 to 116d999 Compare December 9, 2025 04:55
@hawkingrei
tool: upgrade mysql-tester to show the diff
ad5353e 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei force-pushed the upgrade_mysql_tester branch from 116d999 to ad5353e Compare December 9, 2025 11:27
@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 9, 2025

/retest

2 similar comments
@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 9, 2025

/retest

@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 9, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit 9802ef9 into pingcap:master Dec 9, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zimulala zimulala zimulala approved these changes

@YangKeao YangKeao YangKeao approved these changes

@xhebox xhebox Awaiting requested review from xhebox

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hawkingrei @lance6716 @zimulala @YangKeao