util/rowcodec: add new row codec lib#7597
Merged
Merged
Conversation
Member
|
How is the progress of this PR? |
Member
|
@coocood friendly ping, any update? |
Member
Author
|
@zz-jason |
Codecov Report
@@ Coverage Diff @@
## master #7597 +/- ##
===========================================
Coverage 81.4444% 81.4444%
===========================================
Files 432 432
Lines 93088 93088
===========================================
Hits 75815 75815
Misses 11857 11857
Partials 5416 5416 |
zz-jason
reviewed
Aug 5, 2019
Member
zz-jason
left a comment
zz-jason
left a comment
There was a problem hiding this comment.
This PR is so huge. Can you split it into several small PRs?
Member
Author
|
@zz-jason |
qw4990
reviewed
Aug 6, 2019
Contributor
|
Should we add some benchmark results in the description? |
qw4990
reviewed
Aug 8, 2019
qw4990
reviewed
Aug 8, 2019
zz-jason
reviewed
Aug 9, 2019
Member
Author
|
@zz-jason PTAL |
zz-jason
reviewed
Aug 12, 2019
| } | ||
| if r.isLarge { | ||
| largeNotNullSorter := (*largeNotNullSorter)(encoder) | ||
| sort.Sort(largeNotNullSorter) |
Member
There was a problem hiding this comment.
why do we need to sort colIDs and the values for each row?
Member
Author
There was a problem hiding this comment.
So we can do binary searches later.
coocood
added
status/LGT2
Contributor
|
/run-all-tests |
Contributor
|
/run-all-tests |
Contributor
|
@coocood merge failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Prepare to implement the new row format described in the proposal
What is changed and how it works?
Add the rowcodec library and tests, not used in TiDB yet.
Check List
Tests
Code changes
This change is