sessionctx: Set foreign_key_checks = OFF#8358
Merged
Merged
Conversation
Add variable validation to show warning when attempting to enable. Makes it clearer to users that TiDB does not yet support FKs
Contributor
|
LGTM |
Member
Member
|
@morgo Please add a unit test case. |
Member
|
/run-all-tests |
Contributor
Author
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Partially address #8349 by making metadata clearer that foreign keys are not supported.
What is changed and how it works?
This does two things:
foreign_key_checkstoOFF(differs from MySQL default)foreign_key_checkstoON. Since this is not supported by TiDB.Check List
Tests
I've manually verified it works. It does not actively change code, since it is currently an unused option - but I can add unit tests if desired.
Code changes
Side effects
Related changes
tidb-ansiblerepository (I'm not sure - I don't think it is required).This change is