executor: do not build range for NullOuterVal in IndexLookUpJoin#8505
Merged
Conversation
Contributor
Author
|
/run-all-tests |
Contributor
Author
winoros
reviewed
Nov 29, 2018
…iyu/tidb into fix_inlj_range_from_handle
Member
|
/run-all-tests |
Contributor
Author
|
/run-integration-ddl-test |
XuHuaiyu
added a commit
to XuHuaiyu/tidb
that referenced
this pull request
Nov 29, 2018
XuHuaiyu
added a commit
to XuHuaiyu/tidb
that referenced
this pull request
Nov 29, 2018
zz-jason
pushed a commit
that referenced
this pull request
Nov 29, 2018
zz-jason
pushed a commit
that referenced
this pull request
Nov 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #8499
Before this PR, the result of the following query is wrong.
What is changed and how it works?
When the innerPlan is a TableReader, the range of PKHanle will be built in buildTableReaderForIndexJoin,
and
NilDatum.GetInt64()will return 0. Thus we read the row withPkHandle=0twice, and get a duplicate result line.When the innerPlan is a IndexReader or IndexLookUpReader, we'll encode the NilDatum, thus no error happens.
Check List
Tests
Code changes
Side effects
none
Related changes
This change is