Fix mpp hang error if some error happens during compile of mpp plan in TiFlash#1533
Merged
Merged
Conversation
Contributor
Author
|
/run-all-tests |
1 similar comment
Contributor
Author
|
/run-all-tests |
tisonkun
reviewed
Mar 11, 2021
Contributor
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
Leave inline comments. Generally a good exception handling.
Contributor
There was a problem hiding this comment.
We could leverage the follow method for logging the exception either. Otherwise we know only it failed but lost the reason.
leiysky
approved these changes
Mar 11, 2021
Contributor
There was a problem hiding this comment.
What about use a more critical word like destroy?
Contributor
Author
There was a problem hiding this comment.
OK, I will use close
Contributor
Author
|
/run-all-tests |
2 similar comments
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
/run-all-tests |
ti-srebot
approved these changes
Mar 11, 2021
windtalker
added
the
status/can-merge
Collaborator
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #1529
Problem Summary:
As the issue described.
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
The root cause is if a mpp task failed in
DispatchMPPTaskstage, TiFlash does not handle the error properly, which makes the query hangs. In this pr, error handle logical is added.Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note