Skip to content

Fix wrong return value of timestamp column if the timestamp value is 1970-01-01 and the timezone offset is negative#1577

Merged
windtalker merged 5 commits into
pingcap:masterfrom
windtalker:timestamp_default_encode
Mar 20, 2021
Merged

Fix wrong return value of timestamp column if the timestamp value is 1970-01-01 and the timezone offset is negative#1577
windtalker merged 5 commits into
pingcap:masterfrom
windtalker:timestamp_default_encode

Conversation

@windtalker
Copy link
Copy Markdown
Contributor

@windtalker windtalker commented Mar 17, 2021

What problem does this PR solve?

Issue Number: close #1572

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

The root cause is Clickhouse's DateLUT only support time starting from 1970-01-01, and in some corner case, the actual time may be 1969-12-31, this pr handle this special case separately

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • Fix wrong return value of timestamp column if the timestamp value is 1970-01-01 and the timezone offset is negative

@windtalker windtalker added needs-cherry-pick-release-4.0 PR which needs to be cherry-picked to release-4.0 needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 type/bugfix This PR fixes a bug. labels Mar 17, 2021
@windtalker
Copy link
Copy Markdown
Contributor Author

windtalker commented Mar 19, 2021

/run-all-tests

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 19, 2021
@windtalker windtalker added the status/can-merge Indicates a PR has been approved by a committer. label Mar 19, 2021
@ti-srebot
Copy link
Copy Markdown
Collaborator

ti-srebot commented Mar 19, 2021

/run-all-tests

@ti-srebot
Copy link
Copy Markdown
Collaborator

ti-srebot commented Mar 19, 2021

@windtalker merge failed.

@windtalker
Copy link
Copy Markdown
Contributor Author

windtalker commented Mar 20, 2021

/run-all-tests

@windtalker windtalker merged commit be6ccc9 into pingcap:master Mar 20, 2021
@windtalker windtalker deleted the timestamp_default_encode branch March 20, 2021 06:12
@ti-srebot ti-srebot mentioned this pull request Mar 20, 2021
Merged
@ti-srebot
Copy link
Copy Markdown
Collaborator

ti-srebot commented Mar 20, 2021

cherry pick to release-4.0 in PR #1601

@ti-srebot ti-srebot mentioned this pull request Mar 20, 2021
Merged
@ti-srebot
Copy link
Copy Markdown
Collaborator

ti-srebot commented Mar 20, 2021

cherry pick to release-5.0 in PR #1602

@windtalker windtalker mentioned this pull request Mar 22, 2021
Merged
ti-srebot added a commit that referenced this pull request Mar 22, 2021
@ti-srebot
Fix wrong return value of timestamp column if the timestamp value is …
0274227 
…`1970-01-01` and the timezone offset is negative (#1577) (#1602)
windtalker added a commit that referenced this pull request Apr 7, 2021
@ti-srebot @windtalker
Fix wrong return value of timestamp column if the timestamp value is …
b88d930 
…`1970-01-01` and the timezone offset is negative (#1577) (#1601)

* cherry pick #1577 to release-4.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* resolve conflict

Co-authored-by: xufei <xufei@pingcap.com>
Co-authored-by: xufei <xufeixw@mail.ustc.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hanfei1991 hanfei1991 hanfei1991 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-cherry-pick-release-4.0 PR which needs to be cherry-picked to release-4.0 needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: insert 1969-12-31 return 1970-01-01 when disable chunk rpc and set timezone

3 participants

@windtalker @ti-srebot @hanfei1991