testing: pageworkload HeavySkewWriteRead support deleting data#6178
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
|
/run-all-tests |
|
Is it possible to detect the bug automatically? Like by checking the wal file size. |
5da4d34 to
ab19397
Compare
I add some metrics about the WAL log file size in this PR #6175. We can add some checks after that. |
02098b8 to
7e3fabf
Compare
|
/run-all-tests |
|
/merge |
|
@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 3a709cb |
|
/merge |
|
@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created: #6286. |
What problem does this PR solve?
Issue Number: ref #6163
Problem Summary:
We do not delete the page and update existing pages in the previous pageworkload
HeavySkewWriteRead. It always appends new pages. So it can not simulate the real workload of delta-tree and cost lots of disk space.We want to use this workload for verifying the bugs reported in #6163
What is changed and how it works?
PSWriter::updatedRandomDatagenerate random data for updating and reading with a bytes length range of [0, buffer_size_max]. Now it is replaced byPSWriter::getRandomDataand the bytes length range is limited in [buffer_size_min, buffer_size_max]. The random data has a smaller range and more stable reading/writing speed.The read/write performance:
Check List
Tests
I run the workload for 20 minutes. After the workload ends, the remaining page num is 757 rather than a large number of pages. And the disk space used for this testing is more reasonable.
Side effects
Documentation
Release note