Skip to content

degrade to armv8.0#6255

Merged
ti-chi-bot merged 5 commits into
pingcap:masterfrom
Lloyd-Pottiger:degrade-arm-support
Nov 7, 2022
Merged

degrade to armv8.0#6255
ti-chi-bot merged 5 commits into
pingcap:masterfrom
Lloyd-Pottiger:degrade-arm-support

Conversation

@Lloyd-Pottiger
Copy link
Copy Markdown
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Nov 6, 2022 •
edited by JaySon-Huang
Loading

Signed-off-by: Lloyd-Pottiger yan1579196623@gmail.com

What problem does this PR solve?

Issue Number: close #6254

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@Lloyd-Pottiger
degrader to armv8.0
7e8a501 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Nov 6, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • solotzg

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 6, 2022
solotzg
solotzg reviewed Nov 6, 2022
View reviewed changes
Comment thread cmake/cpu_features.cmake
@Lloyd-Pottiger
use asimd default
eaf2e64 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 6, 2022
@Lloyd-Pottiger
Copy link
Copy Markdown
Contributor Author

Lloyd-Pottiger commented Nov 6, 2022

/run-all-tests

solotzg
solotzg approved these changes Nov 6, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@solotzg solotzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 6, 2022
solotzg
solotzg reviewed Nov 6, 2022
View reviewed changes
Comment thread cmake/cpu_features.cmake Outdated
# crc32 is optional in v8.0 and mandatory in v8.1. Enable it as __crc32()* is used in lot's of places and even very old ARM CPUs
# support it.
set (COMPILER_FLAGS "${COMPILER_FLAGS} -march=armv8+crc")
set (TEST_FLAG "-march=armv8+crc")
Copy link
Copy Markdown
Contributor

@solotzg solotzg Nov 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these TEST_FLAG used anywhere?

Copy link
Copy Markdown
Contributor Author

@Lloyd-Pottiger Lloyd-Pottiger Nov 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in line 50, set (COMPILER_FLAGS "${COMPILER_FLAGS} ${TEST_FLAG}") append it to COMPILER_FLAGS.

Copy link
Copy Markdown
Contributor

@solotzg solotzg Nov 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is no need to invoke check_cxx_source_compiles, why not set COMPILER_FLAGS directly.

Copy link
Copy Markdown
Contributor Author

@Lloyd-Pottiger Lloyd-Pottiger Nov 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@Lloyd-Pottiger
Copy link
Copy Markdown
Contributor Author

Lloyd-Pottiger commented Nov 6, 2022

/run-integration-test

@Lloyd-Pottiger
set COMPILER_FLAGS directly
4938457 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 6, 2022
@Lloyd-Pottiger
fix fullstack-test
769b9d5 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 6, 2022
@JaySon-Huang
Copy link
Copy Markdown
Contributor

JaySon-Huang commented Nov 6, 2022

/run-all-tests

JaySon-Huang
JaySon-Huang reviewed Nov 6, 2022
View reviewed changes
Comment thread tests/fullstack-test2/ddl/alter_pk.test
## create table with `source` is nullable
## insert some data and left `source` to be empty
mysql> create table test.t_case (`case_no` varchar(32) not null,`source` varchar(20) default null,`p` varchar(12) DEFAULT NULL,primary key (`case_no`));
mysql> create table test.t_case (`case_no` varchar(32) not null,`source` varchar(20) default null,`p` varchar(12) DEFAULT NULL,primary key (`case_no`) NONCLUSTERED);
Copy link
Copy Markdown
Contributor

@JaySon-Huang JaySon-Huang Nov 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introduced by pingcap/tidb#37384 and pingcap/tidb#38447 that change the default value of tidb_enable_clustered_index from INT_ONLY to ON

@JaySon-Huang
Copy link
Copy Markdown
Contributor

JaySon-Huang commented Nov 6, 2022

/rebuild

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 6, 2022
@Lloyd-Pottiger
Copy link
Copy Markdown
Contributor Author

Lloyd-Pottiger commented Nov 6, 2022

/rebuild

@Lloyd-Pottiger
Copy link
Copy Markdown
Contributor Author

Lloyd-Pottiger commented Nov 6, 2022

/build

@jayl1e
Copy link
Copy Markdown
Contributor

jayl1e commented Nov 6, 2022

/rebuild

@JaySon-Huang
Copy link
Copy Markdown
Contributor

JaySon-Huang commented Nov 6, 2022

/run-all-tests

@JaySon-Huang
Copy link
Copy Markdown
Contributor

JaySon-Huang commented Nov 6, 2022

/run-integration-test

@Lloyd-Pottiger
Copy link
Copy Markdown
Contributor Author

Lloyd-Pottiger commented Nov 7, 2022

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Nov 7, 2022

@Lloyd-Pottiger: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Nov 7, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 58128a5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 7, 2022
@ti-chi-bot ti-chi-bot merged commit 7007ff9 into pingcap:master Nov 7, 2022
@Lloyd-Pottiger Lloyd-Pottiger deleted the degrade-arm-support branch November 7, 2022 01:19
@Lloyd-Pottiger
Copy link
Copy Markdown
Contributor Author

Lloyd-Pottiger commented Nov 7, 2022

/cherry-pick release-6.4

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 7, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Nov 7, 2022

@Lloyd-Pottiger: new pull request created: #6256.

Details

In response to this:

/cherry-pick release-6.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot added a commit that referenced this pull request Nov 7, 2022
@ti-chi-bot
degrade to armv8.0 (#6255) (#6256)
806f71c 
close #6254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@solotzg solotzg solotzg approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6.4.0 fails to start on Phytium arm platform

5 participants

@Lloyd-Pottiger @ti-chi-bot @JaySon-Huang @jayl1e @solotzg