Skip to content

Support regexp_substr function#6316

Merged
ti-chi-bot merged 138 commits into
pingcap:masterfrom
xzhangxian1008:substr
Dec 1, 2022
Merged

Support regexp_substr function#6316
ti-chi-bot merged 138 commits into
pingcap:masterfrom
xzhangxian1008:substr

Conversation

@xzhangxian1008
Copy link
Copy Markdown
Contributor

@xzhangxian1008 xzhangxian1008 commented Nov 15, 2022

What problem does this PR solve?

Issue Number: ref #6115

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@xzhangxian1008
save
8c5768b
@xzhangxian1008
save
8b9c149
@xzhangxian1008
Merge branch 'master' of https://github.com/pingcap/tiflash into empt…
f4aeb00 
…y_pattern
@xzhangxian1008
Merge branch 'master' of https://github.com/pingcap/tiflash into empt…
c9922bc 
…y_pattern
@xzhangxian1008
ready to compile
c98b151
@xzhangxian1008
successfully compile
c126dc5
@xzhangxian1008
Merge branch 'master' of https://github.com/pingcap/tiflash into empt…
2eabd61 
…y_pattern
@xzhangxian1008
clean up
51ff173
@xzhangxian1008
Merge branch 'master' of https://github.com/pingcap/tiflash into empt…
74d7096 
…y_pattern
@xzhangxian1008
Merge branch 'master' of https://github.com/pingcap/tiflash into empt…
32879c2 
…y_pattern
@xzhangxian1008
Merge branch 'master' of https://github.com/pingcap/tiflash into empt…
1adc613 
…y_pattern
@xzhangxian1008
pass tests, for the moment
573f877
@xzhangxian1008
Merge branch 'master' of https://github.com/pingcap/tiflash into empt…
08f3305 
…y_pattern
@xzhangxian1008
pass gtests
101c4ff
@xzhangxian1008
ut passed
2be0ea7
@xzhangxian1008
Merge branch 'master' of https://github.com/pingcap/tiflash into empt…
7150b5f 
…y_pattern
@xzhangxian1008
format
61baf63
@xzhangxian1008
fix ut
74f090e
@xzhangxian1008
Merge branch 'master' of https://github.com/pingcap/tiflash into empt…
46a0499 
…y_pattern
@xzhangxian1008
save works
5f1d1f8
@xzhangxian1008
Merge branch 'master' of https://github.com/pingcap/tiflash into empt…
db38cf4 
…y_pattern
@xzhangxian1008
pass compilation
1de2747
@xzhangxian1008
format
fdade39
@xzhangxian1008
add the convertion of int col
9a03b7a
@xzhangxian1008
Merge branch 'master' of https://github.com/pingcap/tiflash into empt…
a6ede08 
…y_pattern
@xzhangxian1008
undef
c5e6672
@xzhangxian1008
save works
8f44a5d
@xzhangxian1008
Merge branch 'master' of https://github.com/pingcap/tiflash into empt…
291fcc8 
…y_pattern
@xzhangxian1008
tweaking
efb2d73
@xzhangxian1008
resolve
5a4b64a
@ti-chi-bot ti-chi-bot requested a review from SeaRise November 28, 2022 07:28
windtalker
windtalker reviewed Nov 29, 2022
View reviewed changes
Comment thread dbms/src/Common/OptimizedRegularExpression.h Outdated
Comment thread dbms/src/Common/OptimizedRegularExpression.h Outdated
Comment thread dbms/src/Common/OptimizedRegularExpression.inl.h
Comment thread dbms/src/Functions/FunctionsRegexp.h Outdated
Comment thread dbms/src/Functions/FunctionsRegexp.h Outdated
Comment thread dbms/src/Functions/FunctionsRegexp.h Outdated
Comment thread dbms/src/Functions/FunctionsRegexp.h
@xzhangxian1008
Copy link
Copy Markdown
Contributor Author

xzhangxian1008 commented Nov 29, 2022

/cc @XuHuaiyu

@ti-chi-bot ti-chi-bot requested a review from XuHuaiyu November 29, 2022 08:37
windtalker
windtalker reviewed Nov 30, 2022
View reviewed changes
Comment thread dbms/src/Common/OptimizedRegularExpression.inl.h Outdated
Comment thread dbms/src/Common/OptimizedRegularExpression.inl.h Outdated
Comment thread dbms/src/Functions/FunctionsRegexp.h Outdated
Comment thread dbms/src/Functions/FunctionsRegexp.h Outdated
Comment thread dbms/src/Functions/FunctionsRegexp.h
XuHuaiyu
XuHuaiyu reviewed Nov 30, 2022
View reviewed changes
Comment thread dbms/src/Functions/FunctionsRegexp.h
}

String pat = pat_param.getString(0);
if (unlikely(pat.empty()))
Copy link
Copy Markdown
Contributor

@XuHuaiyu XuHuaiyu Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to check whether pos >= 1?

Copy link
Copy Markdown
Contributor Author

@xzhangxian1008 xzhangxian1008 Dec 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to check whether pos >= 1?

Yes, we check position in this file OptimizedRegularExpression.inl.h.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 1, 2022
windtalker
windtalker approved these changes Dec 1, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 1, 2022
@xzhangxian1008
Copy link
Copy Markdown
Contributor Author

xzhangxian1008 commented Dec 1, 2022

/run-all-tests

@xzhangxian1008
Copy link
Copy Markdown
Contributor Author

xzhangxian1008 commented Dec 1, 2022

/run-all-tests

@windtalker
Copy link
Copy Markdown
Contributor

windtalker commented Dec 1, 2022

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Dec 1, 2022

@windtalker: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Dec 1, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 1654586

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 1, 2022
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Dec 1, 2022

@xzhangxian1008: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 89adba9 into pingcap:master Dec 1, 2022
@xzhangxian1008 xzhangxian1008 deleted the substr branch December 1, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@gengliqi gengliqi Awaiting requested review from gengliqi

@SeaRise SeaRise Awaiting requested review from SeaRise

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xzhangxian1008 @ti-chi-bot @windtalker @XuHuaiyu