api,sink: mask sink uri secrets#12643
Conversation
54be364 to
4a80a01
Compare
There was a problem hiding this comment.
Code Review
This pull request introduces comprehensive masking of sensitive data in sink URIs across various modules, including API validation, sink factories, and logging, to prevent credential leakage. It adds utility functions MaskSensitiveDataInURIForError and MaskSensitiveDataInURLError for consistent error handling. The review feedback identifies a missed masking instance in cdc/model/changefeed.go and a minor formatting error in a concatenated string in cdc/sink/validator/validator.go.
|
@asddongmen: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 3AceShowHand, wk989898 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #12642
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note