Skip to content

test(cdc): fix incompatible duplicate entry error message of tidb#7410

Merged
ti-chi-bot merged 3 commits into
masterfrom
fix-incompatible-duplicate-entry-errormessage
Oct 21, 2022
Merged

test(cdc): fix incompatible duplicate entry error message of tidb#7410
ti-chi-bot merged 3 commits into
masterfrom
fix-incompatible-duplicate-entry-errormessage

Conversation

@maxshuang
Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #7409

What is changed and how it works?

add table name to 'duplicate entry' error message for tidb-mysql-test to compatible with pr pingcap/tidb@9743a9a

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

 `None`.

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Oct 20, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • nongfushanquan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 20, 2022
@maxshuang maxshuang changed the title test(test): fix incompatible duplicate entry error message of tidb test(cdc): fix incompatible duplicate entry error message of tidb Oct 20, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 20, 2022

Codecov Report

Merging #7410 (7c4258d) into master (84ef430) will increase coverage by 0.0047%.
The diff coverage is 65.0112%.

Additional details and impacted files
Flag Coverage Δ
cdc 67.5667% <73.5294%> (+0.0722%) ⬆️
dm 51.9967% <100.0000%> (+0.0255%) ⬆️
engine 60.6469% <18.7500%> (-0.2068%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #7410        +/-   ##
================================================
+ Coverage   59.7990%   59.8038%   +0.0047%     
================================================
  Files           801        803         +2     
  Lines         91968      91969         +1     
================================================
+ Hits          54996      55001         +5     
- Misses        32180      32181         +1     
+ Partials       4792       4787         -5     

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 20, 2022
@asddongmen
Copy link
Copy Markdown
Contributor

/run-integration-tests

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 20, 2022
@maxshuang
Copy link
Copy Markdown
Contributor Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2022
@maxshuang
Copy link
Copy Markdown
Contributor Author

The tidb pr that causes the incompatible problem is on the master but not in release-6.3 or other release

@asddongmen
Copy link
Copy Markdown
Contributor

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2022
@asddongmen
Copy link
Copy Markdown
Contributor

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 9bcb169

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 21, 2022
@asddongmen
Copy link
Copy Markdown
Contributor

/run-all-tests

@ti-chi-bot
Copy link
Copy Markdown
Member

@maxshuang: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 73a998d into master Oct 21, 2022
@sleepymole sleepymole deleted the fix-incompatible-duplicate-entry-errormessage branch October 28, 2022 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CDC: incompatible duplicate entry error message of tidb fails the tidb-mysql-test tests

5 participants