Skip to content

*: add metric for FlushRowChangedEvents in sinkDriver#833

Merged
ti-srebot merged 8 commits into
pingcap:masterfrom
wjhuang2016:add_metric
Aug 12, 2020
Merged

*: add metric for FlushRowChangedEvents in sinkDriver#833
ti-srebot merged 8 commits into
pingcap:masterfrom
wjhuang2016:add_metric

Conversation

@wjhuang2016
Copy link
Copy Markdown
Member

What problem does this PR solve?

Add metric

What is changed and how it works?

Check List

Tests

  • No code

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
1
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
a
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 10, 2020

CLA assistant check
All committers have signed the CLA.

@wjhuang2016
Copy link
Copy Markdown
Member Author

/run-monitor-test

@wjhuang2016 wjhuang2016 changed the title Add metric for FlushRowChangedEvents in sinkDriver *: add metric for FlushRowChangedEvents in sinkDriver Aug 10, 2020
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
Comment thread cdc/processor.go
@overvenus
Copy link
Copy Markdown
Member

/lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 11, 2020
@zier-one
Copy link
Copy Markdown
Contributor

/lgtm

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 11, 2020
@zier-one
Copy link
Copy Markdown
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 11, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

Your auto merge job has been accepted, waiting for:

  • 831

@ti-srebot
Copy link
Copy Markdown
Contributor

/run-all-tests

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 11, 2020

Codecov Report

Merging #833 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master       #833   +/-   ##
===========================================
  Coverage   32.2762%   32.2762%           
===========================================
  Files            97         97           
  Lines         10847      10847           
===========================================
  Hits           3501       3501           
  Misses         7010       7010           
  Partials        336        336           

@zier-one
Copy link
Copy Markdown
Contributor

/merge

@ti-srebot
Copy link
Copy Markdown
Contributor

Your auto merge job has been accepted, waiting for:

  • 831

@zier-one
Copy link
Copy Markdown
Contributor

/merge

@ti-srebot
Copy link
Copy Markdown
Contributor

Your auto merge job has been accepted, waiting for:

  • 831

@ti-srebot
Copy link
Copy Markdown
Contributor

/run-all-tests

@ti-srebot
Copy link
Copy Markdown
Contributor

@wjhuang2016 merge failed.

@ti-srebot
Copy link
Copy Markdown
Contributor

/run-all-tests

@ti-srebot
Copy link
Copy Markdown
Contributor

@wjhuang2016 merge failed.

@zier-one
Copy link
Copy Markdown
Contributor

/merge

@ti-srebot
Copy link
Copy Markdown
Contributor

Your auto merge job has been accepted, waiting for:

  • 831

@ti-srebot
Copy link
Copy Markdown
Contributor

/run-all-tests

@ti-srebot
Copy link
Copy Markdown
Contributor

@wjhuang2016 merge failed.

@amyangfei
Copy link
Copy Markdown
Contributor

Please resolve conflicts

@zier-one
Copy link
Copy Markdown
Contributor

/merge

@ti-srebot
Copy link
Copy Markdown
Contributor

/run-all-tests

@ti-srebot
Copy link
Copy Markdown
Contributor

@wjhuang2016 merge failed.

@amyangfei
Copy link
Copy Markdown
Contributor

/merge

@ti-srebot
Copy link
Copy Markdown
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit aee9701 into pingcap:master Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants