refine file gc in file sorter#850
Merged
Merged
Conversation
Contributor
Author
|
/run-integration-tests |
Contributor
|
/lgtm |
zier-one
approved these changes
Aug 17, 2020
ti-srebot
approved these changes
Aug 17, 2020
Contributor
|
@amyangfei please resolve the conflicts |
Contributor
Author
|
/merge |
ti-srebot
added
the
status/can-merge
Contributor
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #850 +/- ##
===========================================
Coverage 33.2256% 33.2256%
===========================================
Files 97 97
Lines 11148 11148
===========================================
Hits 3704 3704
Misses 7075 7075
Partials 369 369 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
If a puller is canceled, some files may be remained in the
toRemoveFileslist and not fully removed.What is changed and how it works?
Check List
Tests
Release note