Skip to content

Support to configure multiple PDs in cdc cli#852

Merged
ti-srebot merged 4 commits into
pingcap:masterfrom
amyangfei:cli-support-multiple-pd
Aug 14, 2020
Merged

Support to configure multiple PDs in cdc cli#852
ti-srebot merged 4 commits into
pingcap:masterfrom
amyangfei:cli-support-multiple-pd

Conversation

@amyangfei
Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Fix pingcap/ticdc#341, besides this is also a test case in QA cases.

What is changed and how it works?

  • Allow to pass multiple PD addresses, separated by comma
  • Add a --multiple-upstream-pd in start_tidb_cluster script, to allow test cases start multiple PDs in upstream TiDB cluster

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

@amyangfei
Copy link
Copy Markdown
Contributor Author

/run-integration-tests

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 14, 2020
@liuzix
Copy link
Copy Markdown
Contributor

liuzix commented Aug 14, 2020

/lgtm

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 14, 2020
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 14, 2020

Codecov Report

Merging #852 into master will increase coverage by 0.0424%.
The diff coverage is 20.0000%.

@@               Coverage Diff                @@
##             master       #852        +/-   ##
================================================
+ Coverage   33.3484%   33.3908%   +0.0424%     
================================================
  Files            97         97                
  Lines         11005      11006         +1     
================================================
+ Hits           3670       3675         +5     
+ Misses         6972       6968         -4     
  Partials        363        363                

@zier-one
Copy link
Copy Markdown
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 14, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

Your auto merge job has been accepted, waiting for:

  • 851

@ti-srebot
Copy link
Copy Markdown
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 7dedd93 into pingcap:master Aug 14, 2020
@amyangfei amyangfei deleted the cli-support-multiple-pd branch August 14, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

failed to start cdc with multiple pd address

5 participants