Skip to content

*: enhance metrics and exit log#855

Merged
ti-srebot merged 6 commits into
pingcap:masterfrom
overvenus:enhance-metrics-and-log
Aug 18, 2020
Merged

*: enhance metrics and exit log#855
ti-srebot merged 6 commits into
pingcap:masterfrom
overvenus:enhance-metrics-and-log

Conversation

@overvenus
Copy link
Copy Markdown
Member

What problem does this PR solve?

Enhance metrics.

Screen capture

screencapture-172-16-5-71-13000-d-YiGL8hBZ1-test-cluster-cdc-2020-08-17-13_18_21

Check List

Tests

  • Integration test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • No release note.

Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus requested review from amyangfei and liuzix August 17, 2020 05:36
@overvenus overvenus added enhancement status/ptal Could you please take a look? labels Aug 17, 2020
@amyangfei amyangfei added this to the v4.0.5 milestone Aug 17, 2020
Copy link
Copy Markdown
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 18, 2020
@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 18, 2020
@zier-one
Copy link
Copy Markdown
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 18, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

Your auto merge job has been accepted, waiting for:

  • 843
  • 856
  • 854

@ti-srebot
Copy link
Copy Markdown
Contributor

/run-all-tests

@ti-srebot
Copy link
Copy Markdown
Contributor

@overvenus merge failed.

@amyangfei
Copy link
Copy Markdown
Contributor

/merge

@ti-srebot
Copy link
Copy Markdown
Contributor

Your auto merge job has been accepted, waiting for:

  • 836

@ti-srebot
Copy link
Copy Markdown
Contributor

/run-all-tests

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #855 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master       #855   +/-   ##
===========================================
  Coverage   33.7779%   33.7779%           
===========================================
  Files            97         97           
  Lines         11096      11096           
===========================================
  Hits           3748       3748           
  Misses         6975       6975           
  Partials        373        373           

@ti-srebot ti-srebot merged commit c883e80 into pingcap:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants