minor optimization for table number scheduler#856
Merged
Conversation
Contributor
Author
|
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## master #856 +/- ##
================================================
- Coverage 33.9865% 33.5173% -0.4692%
================================================
Files 97 97
Lines 11278 11048 -230
================================================
- Hits 3833 3703 -130
+ Misses 7064 6973 -91
+ Partials 381 372 -9 |
Member
|
/lgtm |
zier-one
approved these changes
Aug 18, 2020
ti-srebot
approved these changes
Aug 18, 2020
Contributor
|
/merge |
Contributor
|
Your auto merge job has been accepted, waiting for:
|
ti-srebot
added
the
status/can-merge
Contributor
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When the table count is exactly an integral multiple of capture numbers, the table number based scheduler doesn't make an absolutely even scheduling
such as 4 tables, 2 captures, the scheduling result should be 2, 2
What is changed and how it works?
Use float64 to calculate table tableNumberLimiter
Check List
Tests
Release note