Skip to content

tests: disable clustered index in integration test#901

Merged
zier-one merged 2 commits into
pingcap:masterfrom
amyangfei:disable-clustered-index
Sep 1, 2020
Merged

tests: disable clustered index in integration test#901
zier-one merged 2 commits into
pingcap:masterfrom
amyangfei:disable-clustered-index

Conversation

@amyangfei
Copy link
Copy Markdown
Contributor

What problem does this PR solve?

TiDB implements clustered index in 5.0, ref: pingcap/tidb#17044, TiCDC is not compatible with clustered index now

Note: this change will be reverted after TiCDC supports clustered index

What is changed and how it works?

Set @@global.tidb_enable_clustered_index=0 when starting TiDB in integration test

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

@amyangfei
Copy link
Copy Markdown
Contributor Author

/run-all-tests tidb=438945d2948e9abdda2f3c85c3882932ff520678

@amyangfei
Copy link
Copy Markdown
Contributor Author

/run-all-tests tidb=pr/19582

@amyangfei
Copy link
Copy Markdown
Contributor Author

/run-all-tests

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 31, 2020

Codecov Report

Merging #901 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master       #901   +/-   ##
===========================================
  Coverage   34.1857%   34.1857%           
===========================================
  Files            98         98           
  Lines         11379      11379           
===========================================
  Hits           3890       3890           
  Misses         7099       7099           
  Partials        390        390           

@amyangfei amyangfei added the status/ptal Could you please take a look? label Aug 31, 2020
@liuzix
Copy link
Copy Markdown
Contributor

liuzix commented Sep 1, 2020

/lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 1, 2020
@zier-one
Copy link
Copy Markdown
Contributor

zier-one commented Sep 1, 2020

lgtm

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 1, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 1, 2020
@zier-one
Copy link
Copy Markdown
Contributor

zier-one commented Sep 1, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 1, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

/run-all-tests

@ti-srebot
Copy link
Copy Markdown
Contributor

@amyangfei merge failed.

@zier-one
Copy link
Copy Markdown
Contributor

zier-one commented Sep 1, 2020

/rebuild

@zier-one zier-one merged commit 50f4931 into pingcap:master Sep 1, 2020
@amyangfei amyangfei deleted the disable-clustered-index branch September 1, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants