Add elems into FieldType#208
Closed
Xuanwo wants to merge 9 commits into
Closed
Conversation
Contributor
Author
|
The previous change is for testing CI, please ignore. |
|
@Xuanwo can you resolve the conflicts? |
Contributor
Author
|
OK |
Contributor
Author
|
Fixed |
|
Thanks |
Contributor
Author
|
So we got to merge this PR? |
Contributor
|
I think we can close is pr since #217 did the same thing, and has been merged. |
Contributor
Author
|
I had to close my PR after someone else repeated my work. Did I do something wrong? I don't think so. This PR was created in February and the conflict was handled 22 days ago with the review request, but a PR created 17 days ago has already been reviewed and merged. If there were no plans to merge my PR, please let me know in advance. I sincerely hope this doesn't happen again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.