Skip to content

fix tidb_enable_clustered_index only support global variable#1972

Merged
marsishandsome merged 1 commit into
pingcap:masterfrom
marsishandsome:feature/fix-tidb_enable_clustered_index-GLOBAL
Mar 19, 2021
Merged

fix tidb_enable_clustered_index only support global variable#1972
marsishandsome merged 1 commit into
pingcap:masterfrom
marsishandsome:feature/fix-tidb_enable_clustered_index-GLOBAL

Conversation

@marsishandsome
Copy link
Copy Markdown
Collaborator

@marsishandsome marsishandsome commented Mar 19, 2021

What problem does this PR solve?

pingcap/tidb#23270

tidb_enable_clustered_index only support global variable

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

@marsishandsome marsishandsome added the needs-cherry-pick-release-2.4 PR which needs to be cherry-picked to release-2.4 label Mar 19, 2021
@marsishandsome
Copy link
Copy Markdown
Collaborator Author

marsishandsome commented Mar 19, 2021

/run-all-tests

birdstorm
birdstorm approved these changes Mar 19, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome marsishandsome force-pushed the feature/fix-tidb_enable_clustered_index-GLOBAL branch from 8cb8293 to bc6e153 Compare March 19, 2021 02:46
@marsishandsome
Copy link
Copy Markdown
Collaborator Author

marsishandsome commented Mar 19, 2021

/run-all-tests

@marsishandsome marsishandsome force-pushed the feature/fix-tidb_enable_clustered_index-GLOBAL branch from bc6e153 to 8dc75bb Compare March 19, 2021 04:37
@marsishandsome
Copy link
Copy Markdown
Collaborator Author

marsishandsome commented Mar 19, 2021

/run-all-tests

tangenta
tangenta reviewed Mar 19, 2021
View reviewed changes
Comment thread core/src/test/scala/org/apache/spark/sql/IssueTestSuite.scala Outdated
@marsishandsome marsishandsome force-pushed the feature/fix-tidb_enable_clustered_index-GLOBAL branch from 8dc75bb to 69f671c Compare March 19, 2021 06:29
@marsishandsome
Copy link
Copy Markdown
Collaborator Author

marsishandsome commented Mar 19, 2021

/run-all-tests

@marsishandsome marsishandsome force-pushed the feature/fix-tidb_enable_clustered_index-GLOBAL branch from 69f671c to bb05618 Compare March 19, 2021 06:31
@marsishandsome
Copy link
Copy Markdown
Collaborator Author

marsishandsome commented Mar 19, 2021

/run-all-tests

@marsishandsome marsishandsome merged commit 5c0bbe7 into pingcap:master Mar 19, 2021
@ti-srebot
Copy link
Copy Markdown
Collaborator

ti-srebot commented Mar 19, 2021

cherry pick to release-2.4 failed

marsishandsome added a commit to marsishandsome/tispark that referenced this pull request Mar 19, 2021
@marsishandsome
fix tidb_enable_clustered_index only support global variable (pingcap…
57fc96a 
…#1972)
@marsishandsome marsishandsome mentioned this pull request Mar 19, 2021
Merged
marsishandsome added a commit that referenced this pull request Mar 19, 2021
@marsishandsome
fix tidb_enable_clustered_index only support global variable (#1972) (#…
a10b2c8 
…1973)
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
@marsishandsome
fix tidb_enable_clustered_index only support global variable (pingcap…
72a3e92 
…#1972)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@tangenta tangenta tangenta left review comments

@birdstorm birdstorm birdstorm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-cherry-pick-release-2.4 PR which needs to be cherry-picked to release-2.4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marsishandsome @ti-srebot @birdstorm @tangenta