[DNM] Test Replace DirectByteBuffer with HeapByteBuffer #2005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: birdstorm <samuelwyf@hotmail.com>
Contributor
Author
|
/run-all-tests test-flash=true |
Contributor
Author
|
@plevart FYI, once the tests are passed, this PR will be closed and the corresponding PR in |
birdstorm
changed the title
Contributor
Author
|
Tests passed, this PR is closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: birdstorm samuelwyf@hotmail.com
In correspondance with tikv/client-java#155
This PR tests the TiFlash logic with CI, and should NOT be merged.
Using
DirectByteBufferis better in most cases, butHeapByteBufferis the prerequisite for Java 9+ support.