Skip to content

[DNM] TiUP Cluster UI (new)#1172

Closed
baurine wants to merge 66 commits into
pingcap:masterfrom
baurine:tiup-cluster-ui
Closed

[DNM] TiUP Cluster UI (new)#1172
baurine wants to merge 66 commits into
pingcap:masterfrom
baurine:tiup-cluster-ui

Conversation

@baurine
Copy link
Copy Markdown
Contributor

@baurine baurine commented Mar 2, 2021

What problem does this PR solve?

Supply a web UI of tiup cluster component for users to easily deploy and operate a cluster.

Replace the old PR #706 , the old PR has too many conflicts with the latest master branch because the upstream changed too much.

What is changed and how it works?

Add a web UI that includes both backend and frontend.

Compile it by:

$ make embed_cluster_ui
$ UI=1 make

Run it by:

$ bin/tiup-cluster --ui

Access http://ip:8080 in the browser.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Side effects

  • Increased code complexity

Related changes

  • Need to update the documentation

Release notes:

- Supply a web UI of tiup cluster component for user to easily deploy and operate a cluster.

@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 2, 2021
@baurine
Copy link
Copy Markdown
Contributor Author

baurine commented Mar 2, 2021

Some features have broken, still fixing them.

@baurine baurine mentioned this pull request Mar 2, 2021
@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 2, 2021

Codecov Report

Merging #1172 (3445219) into master (b56c8ad) will increase coverage by 3.07%.
The diff coverage is 4.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1172      +/-   ##
==========================================
+ Coverage   26.17%   29.24%   +3.07%     
==========================================
  Files         263      262       -1     
  Lines       18841    19911    +1070     
==========================================
+ Hits         4931     5823     +892     
+ Misses      13144    13079      -65     
- Partials      766     1009     +243     
Flag Coverage Δ
cluster 30.68% <4.66%> (?)
integrate 29.24% <4.66%> (+12.71%) ⬆️
playground 3.09% <ø> (?)
tiup ?
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/cluster/command/upgrade.go 44.44% <0.00%> (ø)
components/cluster/web/backup/model.go 0.00% <0.00%> (ø)
components/cluster/web/backup/service.go 0.00% <0.00%> (ø)
components/cluster/web/uiserver/uiserver.go 0.00% <0.00%> (ø)
components/cluster/web/web.go 0.00% <0.00%> (ø)
pkg/cliutil/ssh.go 13.33% <0.00%> (+13.33%) ⬆️
pkg/cluster/audit/audit.go 9.41% <0.00%> (-54.01%) ⬇️
pkg/cluster/manager/check.go 0.00% <0.00%> (ø)
pkg/cluster/manager/destroy.go 33.33% <0.00%> (+33.33%) ⬆️
pkg/cluster/manager/status.go 0.00% <0.00%> (ø)
... and 248 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b56c8ad...3445219. Read the comment docs.

@AstroProfundis
Copy link
Copy Markdown
Contributor

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2021
@baurine
Copy link
Copy Markdown
Contributor Author

baurine commented Mar 30, 2021

support downgrade a cluster:

image

WeCom20210330-114627@2x

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 13, 2021
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 18, 2021

Codecov Report

❌ Patch coverage is 21.87500% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.51%. Comparing base (150c90b) to head (ab4daa6).
⚠️ Report is 626 commits behind head on master.

⚠️ Current head ab4daa6 differs from pull request most recent head f4d49b7

Please upload reports for the commit f4d49b7 to get more accurate results.

Files with missing lines Patch % Lines
pkg/cliutil/ssh.go 0.00% 10 Missing ⚠️
pkg/cluster/spec/parse_topology.go 0.00% 10 Missing ⚠️
cmd/list.go 57.14% 3 Missing ⚠️
cmd/mirror.go 0.00% 1 Missing ⚠️
pkg/repository/v1manifest/local_manifests.go 50.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (150c90b) and HEAD (ab4daa6). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (150c90b) HEAD (ab4daa6)
unittest 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1172      +/-   ##
==========================================
- Coverage   26.26%   16.51%   -9.76%     
==========================================
  Files         263      145     -118     
  Lines       18960    11470    -7490     
==========================================
- Hits         4980     1894    -3086     
+ Misses      13207     9087    -4120     
+ Partials      773      489     -284     
Flag Coverage Δ
integrate 16.51% <21.87%> (-0.02%) ⬇️
tiup 16.51% <21.87%> (-0.02%) ⬇️
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

@baurine: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kaaaaaaang
Copy link
Copy Markdown
Collaborator

@kaaaaaaang kaaaaaaang closed this Apr 3, 2023
@baurine
Copy link
Copy Markdown
Contributor Author

baurine commented Apr 3, 2023

This PR can be closed because it's replaced by https://github.com/pingcap/tiunimanager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants