specify component binary path

[fredchenbj]

UCP #77

What problem does this PR solve?

Support specifies the binary path when running a component.

What is changed and how it works?

it runs like tiup playground --kv 3 --db 3 --pd 3 --db.binpath /xx/tidb-server --kv.binpath /xx/tikv-server --pd.binpath /xx/pd-server

Tests

• Manual test

[sre-bot]

Thanks for your contribution. If your PR get merged, you will be rewarded 50 points.

[codecov-io]

Codecov Report

Merging #82 into master will increase coverage by 3.96%.
The diff coverage is 20.19%.

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   29.33%   33.29%   +3.96%     
==========================================
  Files          17       18       +1     
  Lines         958      889      -69     
==========================================
+ Hits          281      296      +15     
+ Misses        625      544      -81     
+ Partials       52       49       -3     

Impacted Files	Coverage Δ
cmd/help.go	6.12% <0.00%> (-4.05%)	⬇️
cmd/run.go	0.00% <0.00%> (ø)
cmd/uninstall.go	43.75% <0.00%> (-1.91%)	⬇️
pkg/repository/component.go	0.00% <ø> (ø)
pkg/repository/mirror.go	8.19% <ø> (ø)
pkg/repository/version.go	78.26% <ø> (ø)
cmd/status.go	11.90% <20.00%> (ø)
pkg/repository/repository.go	36.36% <28.57%> (ø)
cmd/update.go	36.06% <31.25%> (+5.47%)	⬆️
cmd/clean.go	18.91% <33.33%> (ø)
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1a8dad...5dbc958. Read the comment docs.

[fredchenbj]

@lonng PTAL

[lonng]

I think we shouldn't change the protocal component:version. Prefer to use a flag --binpath to specify the binary path.

The protocal component:version:binpath could make the user confused. And will introduce more corner case like component:binpath etc...

The protocal component:version can be used in install/update/uninstall.

[fredchenbj]

I think we shouldn't change the protocal component:version. Prefer to use a flag --binpath to specify the binary path.

The protocal component:version:binpath could make the user confused. And will introduce more corner case like component:binpath etc...

The protocal component:version can be used in install/update/uninstall.

I have modified it, please review again. @lonng

[lonng]

@fredchenbj Thanks for your contribution, almost LGTM. It's better to add some integration tests in tests directory, you just need to add some cases to tests/cases.json and put the expected result to tests/expected directory.

[fredchenbj]

@fredchenbj Thanks for your contribution, almost LGTM. It's better to add some integration tests in tests directory, you just should add some case to tests/cases.json and put the expected result to tests/expected directory.

Thanks for your review. Adding integration test is ok, but I don't know the binary path or binary version of component when ci test.

[lonng]

LGTM

[sre-bot]

Congratulation! You have awarded a badge for usability challenge program! Please fill the form to get your reward! http://tidbcommunity.mikecrm.com/QMCv4QL

[sre-bot]

Team fredchenbj complete task #77 and get 50 score, currerent score 50