-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Refactor web orchestration sync to incremental events and isolated recovery #1560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
45e5724
Optimize orchestration sync and sidebar thread snapshots
juliusmarminge bef63d4
Merge origin/main into t3code/ui-perf-regression
juliusmarminge a7dc0c9
Preserve state on no-op deletes and stale turn diffs
juliusmarminge f6feb65
Refactor orchestration event batch cleanup
juliusmarminge 8ec638c
Separate promoted draft cleanup from deleted thread cleanup
juliusmarminge 708762e
Gate thread redirect on bootstrap completion
juliusmarminge 1a4d757
Move sidebar visit state into a UI store
juliusmarminge 9ca7319
Reduce thread hook re-renders in chat shortcuts
juliusmarminge bbb5742
Drive draft promotion through domain events
juliusmarminge eb180fa
Track local dispatch until server acknowledges
juliusmarminge d0823bf
Extract orchestration recovery coordinator for event replay
juliusmarminge a67bb27
Bound thread plan catalog cache memory
juliusmarminge 314edce
Wait for server thread startup before opening plan sidebar
juliusmarminge 0bd63bf
Refine sidebar ordering and thread lookups
juliusmarminge 3bbafdb
Deduplicate repeated preferred sidebar items
juliusmarminge 22a0b5d
Use shared contract types in web code
juliusmarminge 9084cf5
Move thread plan catalog cache helper below constants
juliusmarminge 0e1dfe5
Reduce chat thread catalog churn and guard replay recovery
juliusmarminge ea6a5ae
fix: add latestTurn regression guard to thread.message-sent handler
cursoragent dea02d4
fix: preserve sourceProposedPlan through incremental event path
cursoragent ee8790e
Clear stale source plans after thread revert
juliusmarminge f659da5
Rebind turn diffs to the final assistant message
juliusmarminge a16234f
Fix incremental thread event UI state seeding and remove redundant us…
cursoragent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test event sequence equals bootstrap sequence, causing "ignore"
Medium Severity
promoteDraftThreadViaDomainEventsends an event withsequenceset tofixture.snapshot.snapshotSequence, butaddThreadToSnapshotdoes not increment the snapshot sequence. After bootstrap, the recovery coordinator setslatestSequence = snapshotSequence, so when the domain event arrives with the same sequence,classifyDomainEventreturns"ignore"(sincesequence <= latestSequence). The draft is never cleared and thevi.waitForassertion times out. The event sequence needs to be greater than the bootstrap snapshot'ssnapshotSequence.Additional Locations (1)
apps/web/src/components/ChatView.browser.tsx#L343-L372There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bugbot Autofix determined this is a false positive.
The addThreadToSnapshot function already increments snapshotSequence (line 306:
snapshot.snapshotSequence + 1), so the event sequence (2) is always greater than the bootstrap latestSequence (1), and classifyDomainEvent returns "apply" not "ignore" — the bug report's premise that the sequence is not incremented is incorrect.You can send follow-ups to this agent here.