-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix: map runtime modes to correct permission levels #1587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
juliusmarminge
merged 12 commits into
pingdotgg:main
from
oski646:fix/permission-mode-bypass
Apr 9, 2026
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d9ec964
fix: map runtime modes to correct permission levels and add auto-acce…
oski646 7c6a958
fix: stop silently discarding auto-accept-edits runtime mode
oski646 364cd56
Merge remote-tracking branch 'origin/main' into fix/permission-mode-b…
oski646 b4a130b
Merge remote-tracking branch 'origin/main' into fix/permission-mode-b…
oski646 7a3d964
Fix composer runtime mode hydration
oski646 215e57f
Refactor permission mode test to use it.effect.each
oski646 a4f6644
Merge branch 'main' into fix/permission-mode-bypass
oski646 f0d471c
Merge remote-tracking branch 'origin/main' into fix/permission-mode-b…
oski646 3d31280
Merge remote-tracking branch 'origin/main' into fix/permission-mode-b…
oski646 394c195
Use a select for runtime mode choices
oski646 c6cdbcd
Merge remote-tracking branch 'origin/main' into fix/permission-mode-b…
oski646 6707b61
Merge origin/main into t3code/pr-1587/fix/permission-mode-bypass
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macroscopeapp[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implicit undefined for approval-required lacks exhaustiveness safety
Low Severity
The
runtimeModeToPermissionmap is typed asRecord<string, PermissionMode>and intentionally omits"approval-required", relying onundefinedto propagate through truthy checks and?? "default"fallbacks. Unlike the Codex adapter'smapCodexRuntimeModeswitch statement which gets TypeScript exhaustiveness checking, this string-keyedRecordprovides no compile-time guarantee that allRuntimeModevalues are accounted for. If a new runtime mode is ever added, it would silently fall through toundefined/"default"behavior without any compiler warning. Making this a complete map overRuntimeMode(mapping"approval-required"explicitly to"default") would make the intent clear and get exhaustiveness checking from TypeScript.Reviewed by Cursor Bugbot for commit 6707b61. Configure here.