Replace wait-on with internal desktop resource polling#1600
Merged
juliusmarminge merged 4 commits intomainfrom Mar 31, 2026
Merged
Replace wait-on with internal desktop resource polling#1600juliusmarminge merged 4 commits intomainfrom
juliusmarminge merged 4 commits intomainfrom
Conversation
- Replace `wait-on` with a local resource poller - Keep Electron dev startup waiting for the renderer port and build files - Drop the `wait-on` dependency from desktop package metadata
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
- Replace wait-on helpers with built-in Node modules - Keep resource polling behavior unchanged
- Fail fast when tcpPort is missing or invalid - Guard TCP readiness resolution and cover with tests
aaditagrawal
added a commit
to aaditagrawal/t3code
that referenced
this pull request
Mar 31, 2026
…lling Integrates 3 upstream commits: - Extract project/workspace functionality to Effect services (pingdotgg#1524) - Replace wait-on with internal desktop resource polling (pingdotgg#1600) - Bump Effect catalog dependencies (pingdotgg#1594) Conflict resolution: deleted fork's workspaceEntries.ts (extracted upstream), accepted upstream's gitCoreLayer extraction in serverLayers, preserved fork's SessionTextGenerationLive for GitManager, moved runPromise definition earlier for favicon route handler.
2 tasks
Chrono-byte
pushed a commit
to Chrono-byte/t3code
that referenced
this pull request
Mar 31, 2026
xddinside
referenced
this pull request
in xddinside/t3code
Apr 4, 2026
gigq
pushed a commit
to gigq/t3code
that referenced
this pull request
Apr 6, 2026
Open
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this shit has waaay too many deps for what we need... given recent supply chain attacks, I'm selective about what deps we use, and this is not needed...
Summary
wait-ondependency from the desktop app startup path.waitForResourceshelper that polls for required files and the Electron renderer port.Testing
bun fmt,bun lint,bun typecheck.Note
Low Risk
Limited to the desktop dev startup script and dependency graph; main risk is altered readiness detection (file/TCP polling) potentially affecting local dev startup timing or failure modes.
Overview
Replaces the desktop app’s dev-time
wait-onusage with a small in-repowaitForResourceshelper that polls for required build outputs and the renderer TCP port before launching Electron.Removes the
wait-ondependency fromapps/desktop(and lockfile), and adds clearer timeout errors that list which files/port are still not ready.Written by Cursor Bugbot for commit d29079e. This will update automatically on new commits. Configure here.
Note
Replace
wait-ondependency with internal TCP and file polling in desktop dev scriptwait-onnpm package and replaces it with a new local helperwait-for-resources.mjs.desktopDir) and a TCP port across loopback hosts (127.0.0.1,localhost,::1), throwing after a 120s timeout with a message listing unresolved resources.dev-electron.mjsis updated to callwaitForResourcesinstead ofwaitOn.📊 Macroscope summarized c4e3aaf. 2 files reviewed, 1 issue evaluated, 1 issue filtered, 0 comments posted
🗂️ Filtered Issues
apps/desktop/scripts/wait-for-resources.test.mjs — 0 comments posted, 1 evaluated, 1 filtered
Path.join(tmpDir, "../server/dist")which resolves to a sibling directory oftmpDir(e.g.,/tmp/server/dist). This directory and its contents persist after the test completes, causing test pollution. Consider creating theserver/diststructure insidetmpDirinstead, or add cleanup logic inafterEach. [ Posting failed ]