Map fatal Codex stderr to runtime errors#1615
Merged
juliusmarminge merged 1 commit intomainfrom Mar 31, 2026
Merged
Conversation
- Detect websocket connection failures in process stderr - Emit `runtime.error` with `provider_error` for fatal cases - Keep nonfatal stderr mapped to warnings
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
gigq
pushed a commit
to gigq/t3code
that referenced
this pull request
Apr 6, 2026
Chrono-byte
pushed a commit
to Chrono-byte/t3code
that referenced
this pull request
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runtime.errorwithprovider_errorfor fatal casesWhat Changed
Why
UI Changes
Checklist
Note
Medium Risk
Changes runtime event classification for a subset of
process/stderrmessages, which may affect user-visible error handling and any alerting/retry logic keyed offruntime.warningvsruntime.error. Scope is limited to string-matching a single fatal snippet with added test coverage.Overview
Codex
process/stderrnotifications are now conditionally promoted fromruntime.warningtoruntime.errorwhen the stderr message matches a known fatal websocket-connection failure snippet (emittingclass: "provider_error").Adds a focused lifecycle test to ensure websocket connection stderr is treated as fatal while non-matching stderr remains a warning.
Written by Cursor Bugbot for commit c80f188. This will update automatically on new commits. Configure here.
Note
Map fatal Codex
process/stderrmessages toruntime.erroreventsIn
CodexAdapter.ts,mapToRuntimeEventsnow checksprocess/stderrnotifications against a list of fatal substrings (currently"failed to connect to websocket"). Matching messages produce aruntime.errorwithclass: 'provider_error'instead of aruntime.warning. Non-fatal stderr continues to yieldruntime.warningas before.Macroscope summarized c80f188.