[codex] migrate Effect.fn in apps/server/src/persistence/Migrations.ts

[juliusmarminge]

Summary

• migrate the remaining () => Effect.gen(...) wrapper in apps/server/src/persistence/Migrations.ts to Effect.fn
• keep this PR scoped to a single file as part of the checklist split

Why

• finish the remaining checklist migrations without batching multiple files into one review
• keep exact-empty-arg Effect.gen wrappers out of the codebase

Validation

• bun fmt
• bun lint
• packages/shared: bun run test src/DrainableWorker.test.ts
• apps/server: bun run test src/provider/Layers/EventNdjsonLogger.test.ts src/provider/Layers/ProviderRegistry.test.ts src/provider/Layers/ProviderService.test.ts src/provider/Layers/ProviderAdapterRegistry.test.ts src/keybindings.test.ts src/open.test.ts
• apps/server: bun run test src/orchestration/projector.test.ts
• apps/server: bun run test src/orchestration/Layers/OrchestrationEngine.test.ts -t "returns deterministic read models for repeated reads"
• apps/server: bun run test src/orchestration/Layers/OrchestrationEngine.test.ts -t "archives and unarchives threads through orchestration commands"
• apps/server: bun run test src/orchestration/Layers/OrchestrationEngine.test.ts -t "streams persisted domain events in order"

Notes

• validation was run from the completed checklist scratch branch before splitting these per-file PRs
• bun run test and bun typecheck at the repo root currently fail in apps/web because @effect/atom-react cannot be resolved
• apps/server still has unrelated pre-existing typecheck failures outside this file

Note

Migrate runMigrations in Migrations.ts to use Effect.fn

Rewrites runMigrations in Migrations.ts to use the Effect.fn("runMigrations") pattern instead of an arrow function returning Effect.gen. The generator body and logic are unchanged.

^{Macroscope summarized 60ac1bb.}

---

Note

Low Risk
Pure refactor of the runMigrations wrapper to Effect.fn with unchanged migration execution logic; low risk aside from potential subtle typing/invocation differences.

Overview
Updates runMigrations in apps/server/src/persistence/Migrations.ts to use Effect.fn("runMigrations") instead of an arrow function returning Effect.gen.

The generator body and behavior (logging, loader selection, and returned executed migrations) remain the same; this is a scoped refactor to standardize Effect function definitions.

^{Written by Cursor Bugbot for commit 60ac1bb. This will update automatically on new commits. Configure here.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: efd820ac-903f-43f4-916c-ff352dfde232

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/effect-fn-apps-server-src-persistence-migrations

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}