[codex] migrate Effect.fn in apps/server/src/persistence/NodeSqliteClient.ts

[juliusmarminge]

Summary

• migrate the remaining () => Effect.gen(...) wrapper in apps/server/src/persistence/NodeSqliteClient.ts to Effect.fn
• keep this PR scoped to a single file as part of the checklist split

Why

• finish the remaining checklist migrations without batching multiple files into one review
• keep exact-empty-arg Effect.gen wrappers out of the codebase

Validation

• bun fmt
• bun lint
• packages/shared: bun run test src/DrainableWorker.test.ts
• apps/server: bun run test src/provider/Layers/EventNdjsonLogger.test.ts src/provider/Layers/ProviderRegistry.test.ts src/provider/Layers/ProviderService.test.ts src/provider/Layers/ProviderAdapterRegistry.test.ts src/keybindings.test.ts src/open.test.ts
• apps/server: bun run test src/orchestration/projector.test.ts
• apps/server: bun run test src/orchestration/Layers/OrchestrationEngine.test.ts -t "returns deterministic read models for repeated reads"
• apps/server: bun run test src/orchestration/Layers/OrchestrationEngine.test.ts -t "archives and unarchives threads through orchestration commands"
• apps/server: bun run test src/orchestration/Layers/OrchestrationEngine.test.ts -t "streams persisted domain events in order"

Notes

• validation was run from the completed checklist scratch branch before splitting these per-file PRs
• bun run test and bun typecheck at the repo root currently fail in apps/web because @effect/atom-react cannot be resolved
• apps/server still has unrelated pre-existing typecheck failures outside this file

Note

Migrate makeWithDatabase in NodeSqliteClient.ts to Effect.fn form

Converts the makeWithDatabase factory in NodeSqliteClient.ts from a plain const returning Effect.gen(...) to a named Effect.fn("makeWithDatabase") generator with an explicit Effect.fn.Return<...> return type. This is a mechanical refactor with no changes to control flow, error handling, or data paths.

^{Macroscope summarized fc89310.}

---

Note

Low Risk
Low risk mechanical refactor that only changes how the effect is defined/typed, not the SQL execution, caching, or transaction behavior.

Overview
Refactors apps/server/src/persistence/NodeSqliteClient.ts by converting makeWithDatabase from a const returning Effect.gen(...) into a named Effect.fn("makeWithDatabase") generator with an explicit Effect.fn.Return<...> return type.

The rest of the logic (sqlite compatibility check, statement caching/execution, connection acquisition, and transaction semaphore handling) is preserved; changes are primarily structural/formatting to align with the Effect.fn style.

^{Written by Cursor Bugbot for commit fc89310. This will update automatically on new commits. Configure here.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3b06c927-1c60-44a7-a448-6a3f9d42e065

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/effect-fn-apps-server-src-persistence-nodesqliteclient

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}