[codex] migrate Effect.fn in apps/server/src/provider/Layers/EventNdjsonLogger.ts

[juliusmarminge]

Summary

• migrate the remaining () => Effect.gen(...) wrapper in apps/server/src/provider/Layers/EventNdjsonLogger.ts to Effect.fn
• keep this PR scoped to a single file as part of the checklist split

Why

• finish the remaining checklist migrations without batching multiple files into one review
• keep exact-empty-arg Effect.gen wrappers out of the codebase

Validation

• bun fmt
• bun lint
• packages/shared: bun run test src/DrainableWorker.test.ts
• apps/server: bun run test src/provider/Layers/EventNdjsonLogger.test.ts src/provider/Layers/ProviderRegistry.test.ts src/provider/Layers/ProviderService.test.ts src/provider/Layers/ProviderAdapterRegistry.test.ts src/keybindings.test.ts src/open.test.ts
• apps/server: bun run test src/orchestration/projector.test.ts
• apps/server: bun run test src/orchestration/Layers/OrchestrationEngine.test.ts -t "returns deterministic read models for repeated reads"
• apps/server: bun run test src/orchestration/Layers/OrchestrationEngine.test.ts -t "archives and unarchives threads through orchestration commands"
• apps/server: bun run test src/orchestration/Layers/OrchestrationEngine.test.ts -t "streams persisted domain events in order"

Notes

• validation was run from the completed checklist scratch branch before splitting these per-file PRs
• bun run test and bun typecheck at the repo root currently fail in apps/web because @effect/atom-react cannot be resolved
• apps/server still has unrelated pre-existing typecheck failures outside this file

Note

Migrate Effect.fn usage in EventNdjsonLogger to named function declarations

Refactors EventNdjsonLogger.ts to use the Effect.fn("name")(function* ...) pattern for all generator-based effects. All functions (toLogMessage, makeThreadWriter, makeEventNdjsonLogger, and their nested helpers) are converted to named Effect.fn declarations. Internal logic and runtime behavior are unchanged.

^{Macroscope summarized 55e68ca.}

---

Note

Low Risk
Low risk refactor limited to EventNdjsonLogger.ts, primarily changing Effect function construction/naming without altering IO, batching, or error-handling logic.

Overview
Refactors provider NDJSON event logging to the Effect.fn style. All previously anonymous Effect.gen wrappers in EventNdjsonLogger.ts (including the batch flush, writer resolution, write, and close paths) are replaced with named Effect.fn(...) equivalents, keeping the same best-effort logging behavior and warning-on-failure semantics.

^{Written by Cursor Bugbot for commit 55e68ca. This will update automatically on new commits. Configure here.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: f00d0adf-bdcd-42ba-b497-d61e0655c556

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/effect-fn-apps-server-src-provider-layers-eventndjsonlogger

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}