Skip to content

[codex] migrate Effect.fn in apps/server/src/provider/Layers/ProviderRegistry.ts#1638

Merged
juliusmarminge merged 2 commits intomainfrom
codex/effect-fn-apps-server-src-provider-layers-providerregistry
Apr 1, 2026
Merged

[codex] migrate Effect.fn in apps/server/src/provider/Layers/ProviderRegistry.ts#1638
juliusmarminge merged 2 commits intomainfrom
codex/effect-fn-apps-server-src-provider-layers-providerregistry

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Apr 1, 2026

Summary

  • migrate the remaining () => Effect.gen(...) wrapper in apps/server/src/provider/Layers/ProviderRegistry.ts to Effect.fn
  • keep this PR scoped to a single file as part of the checklist split

Why

  • finish the remaining checklist migrations without batching multiple files into one review
  • keep exact-empty-arg Effect.gen wrappers out of the codebase

Validation

  • bun fmt
  • bun lint
  • packages/shared: bun run test src/DrainableWorker.test.ts
  • apps/server: bun run test src/provider/Layers/EventNdjsonLogger.test.ts src/provider/Layers/ProviderRegistry.test.ts src/provider/Layers/ProviderService.test.ts src/provider/Layers/ProviderAdapterRegistry.test.ts src/keybindings.test.ts src/open.test.ts
  • apps/server: bun run test src/orchestration/projector.test.ts
  • apps/server: bun run test src/orchestration/Layers/OrchestrationEngine.test.ts -t "returns deterministic read models for repeated reads"
  • apps/server: bun run test src/orchestration/Layers/OrchestrationEngine.test.ts -t "archives and unarchives threads through orchestration commands"
  • apps/server: bun run test src/orchestration/Layers/OrchestrationEngine.test.ts -t "streams persisted domain events in order"

Notes

  • validation was run from the completed checklist scratch branch before splitting these per-file PRs
  • bun run test and bun typecheck at the repo root currently fail in apps/web because @effect/atom-react cannot be resolved
  • apps/server still has unrelated pre-existing typecheck failures outside this file

Note

Migrate syncProviders and refresh to named Effect.fn helpers in ProviderRegistry

Refactors ProviderRegistry.ts to use named Effect.fn helpers instead of inline generator arrow functions.

  • Extracts the inline syncProviders arrow function into a named Effect.fn("syncProviders") helper; logic is unchanged.
  • Extracts the inline refresh logic into a named Effect.fn("refresh") helper; the returned refresh property now delegates to it.
  • Named Effect.fn helpers improve stack traces and tracing within the Effect runtime.

Macroscope summarized 323e2c9.


Note

Low Risk
Refactor-only change that wraps existing provider sync/refresh logic in named Effect.fn helpers; behavior should remain the same aside from improved tracing/stack context.

Overview
Refactors ProviderRegistryLive to replace inline Effect.gen/arrow wrappers with named Effect.fn("syncProviders") and Effect.fn("refresh") helpers.

refresh is extracted into a reusable helper and the exported refresh method now delegates to it, while syncProviders keeps the same snapshot update + PubSub publish behavior.

Written by Cursor Bugbot for commit 323e2c9. This will update automatically on new commits. Configure here.

Co-authored-by: codex <codex@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 1, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a028f6c2-6c58-44cc-876d-cd94118923de

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/effect-fn-apps-server-src-provider-layers-providerregistry

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Apr 1, 2026
@juliusmarminge juliusmarminge marked this pull request as ready for review April 1, 2026 16:03
@juliusmarminge juliusmarminge enabled auto-merge (squash) April 1, 2026 16:03
@juliusmarminge juliusmarminge merged commit 80b282e into main Apr 1, 2026
12 of 14 checks passed
@juliusmarminge juliusmarminge deleted the codex/effect-fn-apps-server-src-provider-layers-providerregistry branch April 1, 2026 16:19
gigq pushed a commit to gigq/t3code that referenced this pull request Apr 6, 2026
…Registry.ts (pingdotgg#1638)

Co-authored-by: codex <codex@users.noreply.github.com>
Chrono-byte pushed a commit to Chrono-byte/t3code that referenced this pull request Apr 7, 2026
…Registry.ts (pingdotgg#1638)

Co-authored-by: codex <codex@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant