[codex] migrate Effect.fn in apps/server/src/provider/makeManagedServerProvider.ts

[juliusmarminge]

Summary

• migrate the remaining () => Effect.gen(...) wrapper in apps/server/src/provider/makeManagedServerProvider.ts to Effect.fn
• keep this PR scoped to a single file as part of the checklist split

Why

• finish the remaining checklist migrations without batching multiple files into one review
• keep exact-empty-arg Effect.gen wrappers out of the codebase

Validation

• bun fmt
• bun lint
• packages/shared: bun run test src/DrainableWorker.test.ts
• apps/server: bun run test src/provider/Layers/EventNdjsonLogger.test.ts src/provider/Layers/ProviderRegistry.test.ts src/provider/Layers/ProviderService.test.ts src/provider/Layers/ProviderAdapterRegistry.test.ts src/keybindings.test.ts src/open.test.ts
• apps/server: bun run test src/orchestration/projector.test.ts
• apps/server: bun run test src/orchestration/Layers/OrchestrationEngine.test.ts -t "returns deterministic read models for repeated reads"
• apps/server: bun run test src/orchestration/Layers/OrchestrationEngine.test.ts -t "archives and unarchives threads through orchestration commands"
• apps/server: bun run test src/orchestration/Layers/OrchestrationEngine.test.ts -t "streams persisted domain events in order"

Notes

• validation was run from the completed checklist scratch branch before splitting these per-file PRs
• bun run test and bun typecheck at the repo root currently fail in apps/web because @effect/atom-react cannot be resolved
• apps/server still has unrelated pre-existing typecheck failures outside this file

Note

Migrate makeManagedServerProvider to use Effect.fn-based generator functions

Refactors makeManagedServerProvider.ts to use the Effect.fn naming and direct generator style throughout.

• Converts the main exported factory and the snapshot application logic to named Effect.fn generators.
• Extracts applySnapshotBase as a named Effect.fn and wraps it in applySnapshot, which handles semaphore acquisition separately.
• Refactors the refreshSnapshot value into a callable Effect.fn generator; all call sites updated to invoke it as refreshSnapshot().
• Inlines previously nested Effect.gen initialization directly into the generator body.

^{Macroscope summarized 55d88a6.}

---

Note

Low Risk
Low risk refactor focused on Effect wrapper/naming changes; main behavior risk is around refreshSnapshot now being invoked as a function, which could affect scheduling if any call site was missed.

Overview
Refactors makeManagedServerProvider to wrap the top-level implementation in Effect.fn("makeManagedServerProvider"), and extracts the snapshot-application and refresh logic into named Effect.fn helpers (e.g. applySnapshotBase, refreshSnapshot) for consistent tracing/naming.

Updates periodic refresh and exposed refresh behavior to call refreshSnapshot() (now a function returning an Effect) rather than treating it as an Effect value, while keeping the same semaphore-guarded snapshot update and PubSub publish flow.

^{Written by Cursor Bugbot for commit 55d88a6. This will update automatically on new commits. Configure here.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: e36d89cb-b5d6-449c-b496-73438dcdecc0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/effect-fn-apps-server-src-provider-makemanagedserverprovider

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}