Skip to content

Split PR creation into granular progress stages#1694

Merged
juliusmarminge merged 1 commit intomainfrom
t3code/pr-progress-granularity
Apr 2, 2026
Merged

Split PR creation into granular progress stages#1694
juliusmarminge merged 1 commit intomainfrom
t3code/pr-progress-granularity

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Apr 2, 2026

Summary

  • Breaks PR creation progress into three clearer stages: preparing, generating content, and creating the GitHub pull request.
  • Updates server-side progress emission so PR work reports each phase separately instead of a single coarse status.
  • Aligns the web UI progress stage builder with the new PR lifecycle and expands unit coverage for the updated flow.

Testing

  • Not run (PR description only).

Note

Low Risk
Low risk: changes are limited to progress event labeling/emission and UI stage mapping, with unit tests updated to enforce the new sequence.

Overview
PR creation progress is now reported as three explicit PR sub-stages instead of a single "Creating PR" stage: Preparing PR..., Generating PR content..., and Creating GitHub pull request....

On the server, runPrStep now accepts a progress emitter and emits additional phase_started events around PR content generation and the gh pr create call; the web UI’s buildGitActionProgressStages is updated to mirror these new labels for create_pr and commit_push_pr, with tests expanded/updated to validate the new stage order.

Written by Cursor Bugbot for commit b429974. This will update automatically on new commits. Configure here.

Note

Split PR creation into three granular progress stages

Replaces the single 'Creating PR...' progress event with three sequential stages: 'Preparing PR...', 'Generating PR content...', and 'Creating GitHub pull request...'. The new stages are emitted from runPrStep in GitManager.ts and reflected in buildGitActionProgressStages in GitActionsControl.logic.ts for create_pr and commit_push_pr actions.

Macroscope summarized b429974.

- Show separate prepare, generate, and create PR phases
- Update server and web progress mappings and tests
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 2, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 21ef22fc-002e-433e-8653-bb6f61e9e5f3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch t3code/pr-progress-granularity

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Apr 2, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 2, 2026

Approvability

Verdict: Approved

This PR only changes progress labels shown during PR creation, splitting one stage into three more descriptive stages. No business logic is altered - tests and frontend logic are updated to match the new labels. Low risk UI/UX enhancement.

You can customize Macroscope's approvability policy. Learn more.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 2, 2026

Caution

Review failed

An error occurred during the review process. Please try again later.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch t3code/pr-progress-granularity

Comment @coderabbitai help to get the list of available commands and usage tips.

@juliusmarminge juliusmarminge merged commit 9ea443d into main Apr 2, 2026
12 checks passed
@juliusmarminge juliusmarminge deleted the t3code/pr-progress-granularity branch April 2, 2026 18:24
gigq pushed a commit to gigq/t3code that referenced this pull request Apr 6, 2026
Chrono-byte pushed a commit to Chrono-byte/t3code that referenced this pull request Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant