[codex] Revert stale send spinner fix

[juliusmarminge]

What changed

This PR reverts commit 48481aa9233666ae05a369e0ed7d16e06e024586 (Fix stale send spinner after completed turns (#1700)).

It removes the isSessionActivelyRunningTurn path and restores the previous session-running behavior in the chat composer and session logic tests.

Why

Revert requested for the change introduced in #1700.

Impact

This restores the prior UI behavior for send-spinner and running-turn state handling.

Validation

• bun fmt
• bun lint
• bun typecheck
• bun run --cwd apps/web test src/session-logic.test.ts

Note

Revert stale send spinner fix by replacing isTurnRunning with phase === "running" checks in ChatView

• Removes the isSessionActivelyRunningTurn helper from session-logic.ts and replaces all isTurnRunning references in ChatView.tsx with direct phase === "running" checks.
• isLatestTurnSettled now returns false whenever session.orchestrationStatus === "running", regardless of activeTurnId or the latest turn's completedAt.
• All UI behaviors gated on running state (work indicator, layout key, auto-scroll, timer tick, revert guard, footer isRunning) now derive from phase instead of the removed helper.
• Behavioral Change: the session is now considered active based solely on phase, so any edge cases where isSessionActivelyRunningTurn and phase disagreed will resolve differently.

^{Macroscope summarized 3c9c997.}

---

Note

Medium Risk
Changes how the UI determines “running/settled” state for turns, which can affect spinners, auto-scroll, and checkpoint revert gating in active chats. Scope is limited to session state derivation and related tests, but regressions could be user-visible during turn transitions.

Overview
Reverts the prior “stale running” handling by removing isSessionActivelyRunningTurn and switching ChatView’s running/work checks back to phase === "running".

isLatestTurnSettled is simplified to treat any session.orchestrationStatus === "running" as unsettled, and tests are updated accordingly (including deriveActiveWorkStartedAt expectations), restoring the earlier behavior for latest-turn banners and work timing.

^{Written by Cursor Bugbot for commit 3c9c997. This will update automatically on new commits. Configure here.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: cd4a6ca2-4153-4d7f-899e-09c53b59d5bd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/revert-48481aa-stale-send-spinner

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[juliusmarminge]

cc @hhharryyyyy this overcompensated for some cases.

[macroscopeapp]

Approvability

Verdict: Needs human review

This revert changes runtime behavior for determining when the UI shows working/spinner states. While it simplifies the logic by removing edge-case handling for 'stale' sessions, it affects user-visible loading indicators and scroll behavior, warranting human verification that the previous fix wasn't needed.

^{You can customize Macroscope's approvability policy. Learn more.}