Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions apps/web/src/components/ChatView.browser.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -866,7 +866,7 @@ async function expectComposerActionsContained(): Promise<void> {
}

async function waitForInteractionModeButton(
expectedLabel: "Chat" | "Plan",
expectedLabel: "Build" | "Plan",
): Promise<HTMLButtonElement> {
return waitForElement(
() =>
Expand Down Expand Up @@ -2096,7 +2096,7 @@ describe("ChatView timeline estimator parity (full app)", () => {
});

try {
const initialModeButton = await waitForInteractionModeButton("Chat");
const initialModeButton = await waitForInteractionModeButton("Build");
expect(initialModeButton.title).toContain("enter plan mode");

window.dispatchEvent(
Expand All @@ -2109,7 +2109,7 @@ describe("ChatView timeline estimator parity (full app)", () => {
);
await waitForLayout();

expect((await waitForInteractionModeButton("Chat")).title).toContain("enter plan mode");
expect((await waitForInteractionModeButton("Build")).title).toContain("enter plan mode");

const composerEditor = await waitForComposerEditor();
composerEditor.focus();
Expand All @@ -2125,7 +2125,7 @@ describe("ChatView timeline estimator parity (full app)", () => {
await vi.waitFor(
async () => {
expect((await waitForInteractionModeButton("Plan")).title).toContain(
"return to normal chat mode",
"return to normal build mode",
);
},
{ timeout: 8_000, interval: 16 },
Expand All @@ -2142,7 +2142,7 @@ describe("ChatView timeline estimator parity (full app)", () => {

await vi.waitFor(
async () => {
expect((await waitForInteractionModeButton("Chat")).title).toContain("enter plan mode");
expect((await waitForInteractionModeButton("Build")).title).toContain("enter plan mode");
},
{ timeout: 8_000, interval: 16 },
);
Expand Down
8 changes: 4 additions & 4 deletions apps/web/src/components/ChatView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -1476,7 +1476,7 @@ export default function ChatView({ threadId }: ChatViewProps) {
type: "slash-command",
command: "default",
label: "/default",
description: "Switch this thread back to normal chat mode",
description: "Switch this thread back to normal build mode",
},
] satisfies ReadonlyArray<Extract<ComposerCommandItem, { type: "slash-command" }>>;
const query = composerTrigger.query.trim().toLowerCase();
Expand Down Expand Up @@ -4029,7 +4029,7 @@ export default function ChatView({ threadId }: ChatViewProps) {
<form
ref={composerFormRef}
onSubmit={onSend}
className="mx-auto w-full min-w-0 max-w-[52rem]"
className="mx-auto w-full min-w-0 max-w-208"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated CSS class change included in PR

Low Severity

The max-w-[52rem]max-w-208 class change is unrelated to renaming the interaction mode label. While functionally equivalent in Tailwind v4, this appears to be an accidentally included change that doesn't match the PR's scope.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2bddd7d. Configure here.

data-chat-composer-form="true"
>
<div
Expand Down Expand Up @@ -4284,13 +4284,13 @@ export default function ChatView({ threadId }: ChatViewProps) {
onClick={toggleInteractionMode}
title={
interactionMode === "plan"
? "Plan mode — click to return to normal chat mode"
? "Plan mode — click to return to normal build mode"
: "Default mode — click to enter plan mode"
}
>
<BotIcon />
<span className="sr-only sm:not-sr-only">
{interactionMode === "plan" ? "Plan" : "Chat"}
{interactionMode === "plan" ? "Plan" : "Build"}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Label says "Build" but PR specifies "Code"

Medium Severity

The PR title and description both state the rename is from "Chat" to "Code", but the implementation uses "Build" everywhere instead. The button label, title tooltip text ("normal build mode"), slash-command description, and all test assertions all say "Build". Either the code or the PR description is wrong — worth confirming the intended label.

Additional Locations (2)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2bddd7d. Configure here.

</span>
</Button>

Expand Down
Loading