fix: trim publisherName to prevent Windows auto-update signature#1892
fix: trim publisherName to prevent Windows auto-update signature#1892eriklueh wants to merge 1 commit intopingdotgg:mainfrom
Conversation
mismatch The AZURE_TRUSTED_SIGNING_PUBLISHER_NAME secret contains a trailing space that propagates into app-update.yml. electron-updater does a strict === comparison between this value and the certificate CN, so "T3 Tools Inc " !== "T3 Tools Inc" causes updates to be rejected with "not signed by the application owner". Add .trim() via Config.map to strip whitespace as defense-in-depth.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved This is a simple defensive fix in a build script that trims whitespace from an Azure signing configuration value. The change is minimal, self-contained, and addresses a clear issue where whitespace in the publisher name could break Windows auto-update signature validation. You can customize Macroscope's approvability policy. Learn more. |
|
updated the secret. it definitely doesn't have trailing whitespace now |
mismatch
The AZURE_TRUSTED_SIGNING_PUBLISHER_NAME secret contains a trailing space
that propagates into app-update.yml. electron-updater does a strict === comparison between this value and the certificate CN, so "T3 Tools Inc " !== "T3 Tools Inc" causes updates to be rejected with "not signed by the application owner".
Add .trim() via Config.map to strip whitespace as defense-in-depth.
What Changed
Why
UI Changes
Checklist
Note
Low Risk
Low risk: only normalizes
AZURE_TRUSTED_SIGNING_PUBLISHER_NAMEby trimming whitespace, affecting Windows signing metadata but not altering signing behavior otherwise.Overview
Prevents Windows auto-update signature mismatches by trimming whitespace from
AZURE_TRUSTED_SIGNING_PUBLISHER_NAMEwhen buildingazureSignOptions, ensuring the generated publisher name matches the certificate CN.Reviewed by Cursor Bugbot for commit d1e15e7. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Trim
publisherNameto prevent Windows auto-update signature failuresTrims leading and trailing whitespace from the
AZURE_TRUSTED_SIGNING_PUBLISHER_NAMEenv var in build-desktop-artifact.ts. Whitespace in the publisher name can cause signature verification mismatches during Windows auto-update checks.Macroscope summarized d1e15e7.