Skip to content

Remove Claude subscription-based model adjustment#1899

Merged
juliusmarminge merged 1 commit intomainfrom
feature/remove-claude-model-adjustment
Apr 10, 2026
Merged

Remove Claude subscription-based model adjustment#1899
juliusmarminge merged 1 commit intomainfrom
feature/remove-claude-model-adjustment

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Apr 10, 2026

Summary

  • Remove the subscription-driven model adjustment logic from ClaudeProvider.
  • Return the provider's model list unchanged during Claude status checks.
  • Delete the unused premium subscription normalization and 1M-default flipping code.

Testing

  • Not run (PR description only).
  • Verify Claude provider status responses still include the expected model list shape.
  • Confirm the default model behavior now comes solely from the upstream/provider-provided metadata.

Note

Medium Risk
Changes Claude provider status responses to stop rewriting model capability defaults based on detected subscription, which may alter default context window selection for some users. Risk is limited to provider metadata/UX, with no auth or data handling changes.

Overview
Removes the subscription-tier driven model adjustment in ClaudeProvider that previously promoted the 1m context window option to default for premium plans.

checkClaudeProviderStatus now always returns the models list from settings/built-ins unchanged (while still detecting subscription/auth method for metadata), simplifying behavior and making defaults come solely from the provider model definitions.

Reviewed by Cursor Bugbot for commit 205a70f. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Remove subscription-based default context window adjustment from ClaudeProvider

Removes adjustModelsForSubscription and PREMIUM_SUBSCRIPTION_TYPES from ClaudeProvider.ts. The provider now returns the base models array unchanged for all subscription types. Behavioral Change: premium subscribers no longer have the 1M context window set as the default option.

Macroscope summarized 205a70f.

- Stop rewriting Claude model defaults by subscription tier
- Return provider models unchanged from status checks
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 10, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 8e53e146-51d5-479e-97bf-35ad5716acc1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/remove-claude-model-adjustment

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Apr 10, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 10, 2026

Approvability

Verdict: Needs human review

This PR removes subscription-based context window defaults, changing what premium users see when selecting models. While it's a straightforward deletion by the original author, it's a user-facing behavior change affecting how the product behaves for different subscription tiers, warranting human review.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge juliusmarminge merged commit 678f827 into main Apr 10, 2026
12 checks passed
@juliusmarminge juliusmarminge deleted the feature/remove-claude-model-adjustment branch April 10, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant