Show awaiting response for blocked chats#459
Show awaiting response for blocked chats#459nassimna wants to merge 2 commits intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Screenshot should not be in the pr. |
|
lmao |
Sorry, first time open source PR..., can someone explain more to me, should it be in a comment? |
|
@nassimna the screenshot should just be in the PR description. Not actually added to part of the codebase. |
Summary
Awaiting responsein the sidebar when a thread is blocked on the userWhy
Before this change, the sidebar blocked state was derived from
derivePendingApprovals(...), so only permission approvals showed a dedicated blocked status. Threads waiting on plan-mode questions or other structured user-input prompts still appeared as generic running work.This change broadens that logic to treat both:
as the same user-blocked sidebar state:
Awaiting response.Screenshot
This screenshot shows a thread waiting on a plan question rather than an approval prompt, while the sidebar correctly surfaces
Awaiting response.Testing
Note
Show “Awaiting response” status in the sidebar by using
session-logic.deriveThreadStatusStateto consolidate blocked chatsReplace local status logic with
deriveThreadStatusState, update the pill label to “Awaiting response,” and route sidebar status rendering through the new state; add tests for status derivation and include a new screenshot.📍Where to Start
Start with
deriveThreadStatusStatein session-logic.ts, then see how it is consumed by the sidebar in Sidebar.tsx.Macroscope summarized d6f20b8.