Skip to content

Show awaiting response for blocked chats#459

Closed
nassimna wants to merge 2 commits intopingdotgg:mainfrom
nassimna:t3code/chat-stats-waiting-states-fix
Closed

Show awaiting response for blocked chats#459
nassimna wants to merge 2 commits intopingdotgg:mainfrom
nassimna:t3code/chat-stats-waiting-states-fix

Conversation

@nassimna
Copy link
Copy Markdown
Contributor

@nassimna nassimna commented Mar 8, 2026

Summary

  • surface Awaiting response in the sidebar when a thread is blocked on the user
  • expand the blocked-state logic from approval-only to both unresolved approvals and unresolved structured user-input prompts
  • centralize thread status derivation in shared session logic and add precedence coverage so blocked threads do not appear as generic running work

Why

Before this change, the sidebar blocked state was derived from derivePendingApprovals(...), so only permission approvals showed a dedicated blocked status. Threads waiting on plan-mode questions or other structured user-input prompts still appeared as generic running work.

This change broadens that logic to treat both:

  • unresolved approvals
  • unresolved structured user-input requests

as the same user-blocked sidebar state: Awaiting response.

Screenshot

awaiting-response-sidebar

This screenshot shows a thread waiting on a plan question rather than an approval prompt, while the sidebar correctly surfaces Awaiting response.

Testing

  • bun run --cwd apps/web test -- src/session-logic.test.ts
  • bun lint
  • bun typecheck

Note

Show “Awaiting response” status in the sidebar by using session-logic.deriveThreadStatusState to consolidate blocked chats

Replace local status logic with deriveThreadStatusState, update the pill label to “Awaiting response,” and route sidebar status rendering through the new state; add tests for status derivation and include a new screenshot.

📍Where to Start

Start with deriveThreadStatusState in session-logic.ts, then see how it is consumed by the sidebar in Sidebar.tsx.

Macroscope summarized d6f20b8.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 8, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: e59663b2-d0a9-4ce4-96f7-74dff0a29719

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@t3dotgg
Copy link
Copy Markdown
Member

t3dotgg commented Mar 9, 2026

Screenshot should not be in the pr.

@maria-rcks
Copy link
Copy Markdown
Collaborator

lmao

@github-actions github-actions bot added the vouch:unvouched PR author is not yet trusted in the VOUCHED list. label Mar 9, 2026
@nassimna
Copy link
Copy Markdown
Contributor Author

nassimna commented Mar 9, 2026

Screenshot should not be in the pr.

Sorry, first time open source PR..., can someone explain more to me, should it be in a comment?

@tansawit
Copy link
Copy Markdown

tansawit commented Mar 9, 2026

@nassimna the screenshot should just be in the PR description. Not actually added to part of the codebase.

@maria-rcks
Copy link
Copy Markdown
Collaborator

#701

@maria-rcks maria-rcks closed this Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants