Extend Git Action failure Visibility#672
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This is partially done by #642 |
|
i feel like error toasts shouldn't auto dismiss. if i don't pay attention and the toast dismisses before i come back, there's now no indication that the action i performed failed and i'm left wondering if it ever ran |
makes sense, thanks for the review @juliusmarminge ! also,
|
What Changed
Updated the Git action error toast so it now auto-dismisses after 10 seconds of visible time, matching the existing success toast behavior.
Why
Git action failures were reusing a persistent progress toast created with timeout: 0, but unlike the success path, the error path never opted back into auto-dismiss behavior. That made failed action toasts stay on screen indefinitely, which was inconsistent with successful action toasts and looked like an accidental sticky state rather than an intentional UX choice.
This change fixes that inconsistency with the smallest possible scope and no broader toast-system behavior changes.
This fix resolves the issue #390 and #419
UI Changes
Before the fix
the toast would stick forever, only way to dismiss it was by sliding it off.
before.mp4
After the fix
the toast now auto-dismisses after 10 seconds of visible time.
after.mp4
Checklist
Note
Set error toast dismissal to 10,000 ms in
GitActionsControlto extend Git Action failure visibility in GitActionsControl.tsxOn mutation failure in
GitActionsControl, updatetoastManager.updateto spreadthreadToastDataand adddismissAfterVisibleMs: 10_000in GitActionsControl.tsx.📍Where to Start
Start with the error path in the
runImmediateGitActionMutationhandler withinGitActionsControlin GitActionsControl.tsx.Macroscope summarized c757e9a.