Skip to content

Extend Git Action failure Visibility#672

Closed
laxman-patel wants to merge 1 commit intopingdotgg:mainfrom
laxman-patel:patch-1
Closed

Extend Git Action failure Visibility#672
laxman-patel wants to merge 1 commit intopingdotgg:mainfrom
laxman-patel:patch-1

Conversation

@laxman-patel
Copy link
Copy Markdown

@laxman-patel laxman-patel commented Mar 9, 2026

What Changed

Updated the Git action error toast so it now auto-dismisses after 10 seconds of visible time, matching the existing success toast behavior.

Why

Git action failures were reusing a persistent progress toast created with timeout: 0, but unlike the success path, the error path never opted back into auto-dismiss behavior. That made failed action toasts stay on screen indefinitely, which was inconsistent with successful action toasts and looked like an accidental sticky state rather than an intentional UX choice.

This change fixes that inconsistency with the smallest possible scope and no broader toast-system behavior changes.

This fix resolves the issue #390 and #419

UI Changes

Before the fix

the toast would stick forever, only way to dismiss it was by sliding it off.

before.mp4

After the fix

the toast now auto-dismisses after 10 seconds of visible time.

after.mp4

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Set error toast dismissal to 10,000 ms in GitActionsControl to extend Git Action failure visibility in GitActionsControl.tsx

On mutation failure in GitActionsControl, update toastManager.update to spread threadToastData and add dismissAfterVisibleMs: 10_000 in GitActionsControl.tsx.

📍Where to Start

Start with the error path in the runImmediateGitActionMutation handler within GitActionsControl in GitActionsControl.tsx.

Macroscope summarized c757e9a.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 9, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 301fb631-77c6-4da3-8b2d-1ff1ff99f560

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the vouch:unvouched PR author is not yet trusted in the VOUCHED list. label Mar 9, 2026
@binbandit
Copy link
Copy Markdown
Contributor

This is partially done by #642

@juliusmarminge
Copy link
Copy Markdown
Member

i feel like error toasts shouldn't auto dismiss. if i don't pay attention and the toast dismisses before i come back, there's now no indication that the action i performed failed and i'm left wondering if it ever ran

@laxman-patel
Copy link
Copy Markdown
Author

laxman-patel commented Mar 11, 2026

i feel like error toasts shouldn't auto dismiss. if i don't pay attention and the toast dismisses before i come back, there's now no indication that the action i performed failed and i'm left wondering if it ever ran

makes sense, thanks for the review @juliusmarminge !

also,

  1. Would a close (cross) button to dismiss be appropriate?
  2. What about auto-dismiss progress bar for the toasts with dismissAfterVisibleMs property?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants