fix: Pending user input displays with "Pending Approval" status

[cameronmolen]

What Changed

• show Pending Approval when either approvals or user input are pending
• move thread status pill derivation into Sidebar.logic.ts
• add unit tests for status priority and unseen completion behavior

Why

Issue #442:

• If an agent in plan mode asks a question, there is no visual indicator for that in the sidebar. This makes knowing that the user needs to take some action impossible without opening up the thread.

Cause:

• pendingUserInput was not being considered for the "Pending Approval" status.

UI Changes

Before

before.mov

After

after.mov

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes
• I included a video for animation/interaction changes

Note

Treat pending user-input as "Pending Approval" and centralize status pill resolution via Sidebar.logic.resolveThreadStatusPill in Sidebar.tsx

Move status pill logic into Sidebar.logic.resolveThreadStatusPill and add hasUnseenCompletion; update Sidebar.tsx to use the resolver and derive pending user input; add tests in Sidebar.logic.test.ts.

📍Where to Start

Start with resolveThreadStatusPill and hasUnseenCompletion in Sidebar.logic.ts.

^{Macroscope summarized b2259aa.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 54099e9a-cbe9-4901-a24e-1d4266e1263b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[notkainoa]

+1 for this

[notkainoa]

In my opinion, "input needed" might be better than "pending approval"

[juliusmarminge]

#701