Skip to content

Use go tool command for tool invocations #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henryrecker-pingidentity merged 1 commit into from
May 12, 2025
Merged

Use go tool command for tool invocations #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/code-analysis-lint-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ jobs:
with:
go-version-file: "go.mod"
cache: true
- run: go install github.com/pavius/impi/cmd/impi && make importfmtlint
- run: make importfmtlint
test:
name: go test
needs: [build]
Expand Down
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ devcheck: devchecknotest spincontainer test removetestcontainer

importfmtlint:
@echo -n "Running 'impi' to format import ordering..."
@if impi --local . --scheme stdThirdPartyLocal ./...; then \
@if go tool impi --local . --scheme stdThirdPartyLocal ./...; then \
echo " SUCCESS"; \
else \
echo " FAILED"; \
Expand All @@ -111,7 +111,7 @@ importfmtlint:
golangcilint:
@echo -n "Running 'golangci-lint' to check for code quality issues... "
@# Clear the cache for every run, so that the linter outputs the same results as the GH Actions workflow
@golangci-lint cache clean && golangci-lint run --timeout 5m ./...
@go tool golangci-lint cache clean && go tool golangci-lint run --timeout 5m ./...

starttestcontainer: --checkpfcontainerenvvars --checkdocker --dockerrunpf --waitforpfhealthy

Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ go 1.24.1

tool (
github.com/golangci/golangci-lint/cmd/golangci-lint
github.com/pavius/impi
github.com/pavius/impi/cmd/impi
)

require (
Expand Down