CDI-588: Fix --config Global Flag When Creating Profile#120
Merged
erikostien-pingidentity merged 3 commits intomainfrom Sep 10, 2025
Merged
CDI-588: Fix --config Global Flag When Creating Profile#120erikostien-pingidentity merged 3 commits intomainfrom
--config Global Flag When Creating Profile#120erikostien-pingidentity merged 3 commits intomainfrom
Conversation
Contributor
erikostien-pingidentity
commented
Aug 19, 2025
erikostien-pingidentity
commented
- Update root.go to only initialize the koanf profile by manually parsing the --config flag and its variations. This is necessary because of a chicken and then egg problem created by cobra when interacting with our plugins and the --help flag.
- Update root.go to only initialize the koanf profile after all of the flags have been parsed (which only occurs when the command's Execute() function is invoked).
henryrecker-pingidentity
approved these changes
Aug 19, 2025
patrickcping
requested changes
Aug 20, 2025
Contributor
patrickcping
left a comment
patrickcping
left a comment
There was a problem hiding this comment.
Needs unit and regression tests added
wesleymccollam
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.