PDI-2056: [UAT] Update --profile Flags Functionality#15
Merged
erikostien-pingidentity merged 3 commits intomainfrom Oct 17, 2024
Merged
PDI-2056: [UAT] Update --profile Flags Functionality#15erikostien-pingidentity merged 3 commits intomainfrom
erikostien-pingidentity merged 3 commits intomainfrom
Conversation
Contributor
erikostien-pingidentity
commented
Oct 17, 2024
erikostien-pingidentity
commented
- Make --active-profile global flag be --profile instead.
- Have the --profile flag only apply for this instance of command it is specified, where it does not update nor affect the configuration file's activeProfile configuration.
- Update config commands to use --profile-name instead of --profile to avoid flag collisions with the global flag.
- Make --active-profile global flag be --profile instead. - Have the --profile flag only apply for this instance of command it is specified, where it does not update nor affect the configuration file's activeProfile configuration. - Update config commands to use --profile-name instead of --profile to avoid flag collisions with the global flag.
- Update all PFlag structs to remove DefValue and manually add default information to Usage field. - Also remove config command logic.
This reverts commit 039444e.
henryrecker-pingidentity
approved these changes
Oct 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.