Skip to content

Comments

PDI-2121: All secrets should be masked in output#61

Merged
erikostien-pingidentity merged 5 commits intomainfrom
PDI-2121
Jan 7, 2025
Merged

PDI-2121: All secrets should be masked in output#61
erikostien-pingidentity merged 5 commits intomainfrom
PDI-2121

Conversation

@erikostien-pingidentity
Copy link
Contributor

@erikostien-pingidentity erikostien-pingidentity commented Jan 6, 2025

  • Update Option Struct to support Sensitive field.
  • Update all config commands to use MaskValue on sensitive options, and flatten yaml structure output to key=value lines.
  • Add test cases on config command output expectations.

- Update Option Struct to support Sensitive field
- Update all GetOptionValue calls on sensitive Options to use
the new function GetSensitiveOptionValue
- Update all config commands to use GetOptionValue
and GetSensitiveOptionValue where relevant, and flatten yaml
structure output to key=value lines.
@erikostien-pingidentity erikostien-pingidentity requested a review from a team as a code owner January 6, 2025 20:56
@erikostien-pingidentity erikostien-pingidentity merged commit c9adaa9 into main Jan 7, 2025
8 checks passed
@erikostien-pingidentity erikostien-pingidentity deleted the PDI-2121 branch January 7, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants