Skip to content

Comments

Add HCL generation advice header#8

Merged
erikostien-pingidentity merged 3 commits intomainfrom
add-import-block-doc-header-202410
Oct 16, 2024
Merged

Add HCL generation advice header#8
erikostien-pingidentity merged 3 commits intomainfrom
add-import-block-doc-header-202410

Conversation

@patrickcping
Copy link
Contributor

  • Add a header to each generated file that states:

    • The origin (Ping CTL)
    • The date/time of generation (to compare with other generated files)
    • Advice on the import {} block use with linkout to Hashicorp's docs
    • Advice on working through plan errors
  • Add a new doc that describes the manual actions that need to be taken to work around terraform plan errors generated by the provider, due to config generation limitations out of our control

Copy link
Contributor

@erikostien-pingidentity erikostien-pingidentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I think a small test case expected error changed with the header logic that needs to be addressed.

@patrickcping patrickcping marked this pull request as ready for review October 15, 2024 17:29
@patrickcping patrickcping requested a review from a team as a code owner October 15, 2024 17:29
@erikostien-pingidentity erikostien-pingidentity merged commit 095524c into main Oct 16, 2024
@erikostien-pingidentity erikostien-pingidentity deleted the add-import-block-doc-header-202410 branch October 16, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants