Add HCL generation advice header#8
Merged
erikostien-pingidentity merged 3 commits intomainfrom Oct 16, 2024
Merged
Conversation
erikostien-pingidentity
approved these changes
Oct 15, 2024
Contributor
erikostien-pingidentity
left a comment
There was a problem hiding this comment.
Looks great! I think a small test case expected error changed with the header logic that needs to be addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a header to each generated file that states:
import {}block use with linkout to Hashicorp's docsAdd a new doc that describes the manual actions that need to be taken to work around
terraform planerrors generated by the provider, due to config generation limitations out of our control