Updated stub to use all the paths of view finder #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When some extension already extended \Illuminate\View\FileViewFinder with additional view paths, we need to consider all of them. Example: https://github.com/igaster/laravel-theme Here paths will be like resources/<theme>/views, resources/views - we need to check modules template files in all of them (according to themes fallback). So, in our case it will become resources/<theme>/views/module/<module> and resources/views/module/<module> (last one is the same as `$viewPath` variable. Why not publishes themes templates? IMO, modules should not be supplied with strange themes, unless it is module bringing specific theme, but in this case this module provider could do publish by itself. Thanks
gravitano
added a commit
that referenced
this pull request
Dec 23, 2015
Updated stub to use all the paths of view finder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When some extension already extended \Illuminate\View\FileViewFinder with additional view paths, we need to consider all of them.
Example: https://github.com/igaster/laravel-theme
Here paths will be like:
And we need to check modules template files in all of them (according to themes fallback). So, in our case it will become:
$viewPathvariable).Why not publishes themes templates? IMO, modules should not be supplied with strange themes, unless it is module bringing specific theme, but in this case this module provider could do publish by itself.
Thanks