Skip to content

Fix time initialization in UTC sun position method #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dickermoshe wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Fix time initialization in UTC sun position method #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion zmanim/util/noaa_calculator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def _julian_day_from_julian_centuries(self, julian_centuries: float) -> float:

def _utc_sun_position(self, target_date: date, geo_location: GeoLocation, zenith: float, adjust_for_elevation: bool, mode: str) -> float:
if not isinstance(target_date, datetime):
target_date = datetime.combine(target_date, time())
target_date = datetime.combine(target_date, time.min)
elevation = geo_location.elevation if adjust_for_elevation else 0.0
adjusted_zenith = self.adjusted_zenith(zenith, elevation)
utc_time = self._calculate_utc_sun_position(julian.to_jd(target_date),
Expand Down