Add support for hebrew date formatter #6
+406
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a WIP. It is supposed to mimc the behavior of the HebrewDateFormatter from the KosherJava version. After this commit 2 tests will be added. 1 passes.
Improve format_month coverage to 100% by adding test cases for both Adars. Bugfixes in comparison method.
Add tests for testing numbers
tsvi
changed the title
So as to keep in line with the Java implemetation I changed the order of the enums to match the order used in the formatting
To keep in line with the KosherJava implementation, I changed the name of taanis_esther and tzom_gedalya to 'fast_of_*'
pinnymz
reviewed
Oct 14, 2020
| 'SignificantDays', 'erev_pesach pesach chol_hamoed_pesach pesach_sheni \ | ||
| erev_shavuos shavuos seventeen_of_tammuz \ | ||
| tisha_beav tu_beav erev_rosh_hashana rosh_hashana \ | ||
| fast_of_gedalyah erev_yom_kippur yom_kippur \ |
Owner
There was a problem hiding this comment.
Finally getting to this :)
The naming convention for all significant days was taken from the KosherJava project, and I'd prefer not to deviate unless there were a compelling reason to do so. Also, please note that Lag B'Omer has now been added to the mix, and the spelling has been changed from the 'Lag BaOmer' previously used (in the omer formatting logic).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for formatting hebrew date.
Does not include yet parasha and limudim. Not pythonic yet.
Added unit tests for all code lines.